Unit tests #91
Merged
Unit tests #91
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Merge branch 'UnitTests' of https://github.com/NOAA-EDAB/Rpath into UnitTests # Conflicts: # tests/testthat/test-utils.R
- Used unicode encoding instead of the actual symbol for plots' y labels - Removed crashing species by modifying random number scale factor in modifyFishingMatrix()
…(version=3) was giving a warning in the github action file. As a result the baseline files needed to be regenerated.
Unit tests badge now a function of R-CMD-check
Merge branch 'dev' into UnitTests # Conflicts: # .gitignore # tests/testthat/data/input/REcosystem_Current_AB_ForcedBio_OutBiomass_Jitter.rds
Updating UnitTests to the latest dev
- Added ggwebplot and summarize.for.webplot to pkgdownl.yml
andybeet
reviewed
Nov 13, 2024
|
Yes, I just put them in once to reference their usage in the code.
…-Ron
On Wed, Nov 13, 2024 at 4:14 PM Andy ***@***.***> wrote:
***@***.**** commented on this pull request.
------------------------------
In vignettes/UnitTests.Rmd
<#91 (comment)>:
> +
+14. Compare out_Biomass from baseline AB run and current RK4 sim run
+
+ Checks if OutBiomass is the same for the baseline AB sim run and the current RK4 sim run.
+
+15. Compare out_Catch from baseline AB run and current RK4 sim run
+
+ Checks if OutCatch is the same for the baseline AB sim run and the current RK4 sim run.
+
+16. Compare out_Gear_Catch from baseline AB run and current RK4 sim run
+
+ Checks if OutGearCatch is the same for the baseline AB sim run and the current RK4 sim run.
+
+#### AB and RK4 Sim Run Tests with Jitter on ForcedBiomass:
+
+17. Compare sim runs with random noise (i.e., jitter) added to \$forcing\$ForcedBio
Are the dollar signs intended? Subsequent lines they seem to be omitted
—
Reply to this email directly, view it on GitHub
<#91 (review)>,
or unsubscribe
<https://github.com/notifications/unsubscribe-auth/AGZ6RSFPBXR7ETEE344CYNT2AO6LVAVCNFSM6AAAAABRXEZNW6VHI2DSMVQWIX3LMV43YUDVNRWFEZLROVSXG5CSMV3GSZLXHMZDIMZUGQ2DMMBYGA>
.
You are receiving this because you authored the thread.Message ID:
***@***.***>
--
Ron Klasky
Contractor (remote)
T and T Consulting Services, Inc.
In Support of Office of Science and Technology | Ecosystem Management
NOAA | National Marine Fisheries Service
(321) 765-4465 (o)
(661) 857-4720 (c)
|
|
@kaydin This builds ok for me. Wanted you to take a look too, since the content doesn't mean too much to me |
andybeet
approved these changes
Nov 18, 2024
|
When these were first implemented, did Sean work on these or figure out "correct" outputs? Otherwise may need to start from scratch to hand-calculate correct values. |
|
(previous comment is @rklasky) |
|
The way the Unit Tests were set up was I ran a baseline of all the plots
with a version that Sean had approved. Then all subsequent Unit Tests are
tested against the baseline plots which are kept.
…On Tue, Dec 3, 2024 at 4:18 PM kaydin ***@***.***> wrote:
Merged #91 <#91> into dev.
—
Reply to this email directly, view it on GitHub
<#91 (comment)>, or
unsubscribe
<https://github.com/notifications/unsubscribe-auth/AGZ6RSFPNC6IAAX2AOY34KT2DYN3DAVCNFSM6AAAAABRXEZNW6VHI2DSMVQWIX3LMV45UABCJFZXG5LFIV3GK3TUJZXXI2LGNFRWC5DJN5XDWMJVGUYTMMJWG4YTKNQ>
.
You are receiving this because you were mentioned.Message ID:
***@***.***>
--
Ron Klasky
Contractor (remote)
T and T Consulting Services, Inc.
In Support of Office of Science and Technology | Ecosystem Management
NOAA | National Marine Fisheries Service
(321) 765-4465 (o)
(661) 857-4720 (c)
|
|
Thanks @rklasky, for the record, could you note here what branch/check-in point is being used as the "Sean approved" baseline? |
|
I would if I knew. I think Sean was like just do a baseline "now" and going
forward we'll compare against that. I can generate a new set of baseline
plots if you want to specify a particular branch for me to do that on and
we can track it going forward from now.
…On Wed, Dec 4, 2024 at 12:59 PM kaydin ***@***.***> wrote:
Thanks @rklasky <https://github.com/rklasky>, for the record, could you
note here what branch/check-in point is being used as the "Sean approved"
baseline?
—
Reply to this email directly, view it on GitHub
<#91 (comment)>, or
unsubscribe
<https://github.com/notifications/unsubscribe-auth/AGZ6RSGV55RAOQX2YAJR5A32D47GTAVCNFSM6AAAAABRXEZNW6VHI2DSMVQWIX3LMV43OSLTON2WKQ3PNVWWK3TUHMZDKMJYGE2TQNRVGU>
.
You are receiving this because you were mentioned.Message ID:
***@***.***>
--
Ron Klasky
Contractor (remote)
T and T Consulting Services, Inc.
In Support of Office of Science and Technology | Ecosystem Management
NOAA | National Marine Fisheries Service
(321) 765-4465 (o)
(661) 857-4720 (c)
|
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
I updated the UnitTests vignette and updated the tests.yaml file so as to run unit tests from main, master, or dev.