Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Proxy #1

Closed
wants to merge 33 commits into from
Closed

Proxy #1

wants to merge 33 commits into from

Conversation

Philip-NLnetLabs
Copy link
Member

Initial version of the proxy

@Philip-NLnetLabs Philip-NLnetLabs marked this pull request as draft October 25, 2024 10:06
@Philip-NLnetLabs Philip-NLnetLabs marked this pull request as ready for review November 26, 2024 11:12
@ximon18
Copy link
Member

ximon18 commented Nov 26, 2024

Please update the README to describe the proxy this PR creates.

@ximon18
Copy link
Member

ximon18 commented Nov 26, 2024

Are Windows and MacOS out of scope? I ask because the CI is failing for those platforms.

@Philip-NLnetLabs
Copy link
Member Author

Are Windows and MacOS out of scope? I ask because the CI is failing for those platforms.

It is a problem of one of the rust libraries. I assume it will be fixed over time. If it doesn't we have to figure out what to do.

. IN DS 38696 8 2 683D2D0ACB8C9B712A1948B27F741219298D0A450D612C483AF444A4C0FB2B16
";

/// Arguments parser.
Copy link
Member

@mozzieongit mozzieongit Dec 4, 2024

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I'm not sure how polished this program is supposed to be, but for this review I'm going to assume it's supposed to be "releaseable" and consumable (for trying it out) by a user.

Calling the program with --help prints this line as the help output:

Arguments parser

Usage: domain-simple-proxy <CONFIG>

Arguments:
  <CONFIG>  Configuration

Options:
  -h, --help     Print help
  -V, --version  Print version

@@ -0,0 +1,109 @@
{
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

When publishing this, there should probably also be a config documentation. But the examples might be enough for now.

Copy link
Member

@mozzieongit mozzieongit left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

The code does what is should 👍
The examples have a few mistakes, and the configuration lacks documentation.
I have a few notes on code "quality" (but those won't be merge blocking).

Otherwise, great work.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants