Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

add licensing to best practices chapter #401

Merged
merged 3 commits into from
Dec 4, 2024
Merged

add licensing to best practices chapter #401

merged 3 commits into from
Dec 4, 2024

Conversation

egpbos
Copy link
Member

@egpbos egpbos commented Dec 4, 2024

Fixes #379.

@egpbos egpbos requested a review from c-martinez December 4, 2024 14:20
@egpbos egpbos mentioned this pull request Dec 4, 2024
Closed
4 tasks
@egpbos
Copy link
Member Author

egpbos commented Dec 4, 2024

Fixes #384 as well.

@egpbos egpbos linked an issue Dec 4, 2024 that may be closed by this pull request
Clean-up and replace Intellectual property chapter #384
Closed
4 tasks
bouweandela
bouweandela requested changes Dec 4, 2024
View reviewed changes
Copy link
Member

@bouweandela bouweandela left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

It would be nice to try to avoid acronyms to keep the text readable to outsiders

best_practices/overview.md Outdated Show resolved Hide resolved
best_practices/overview.md Outdated Show resolved Hide resolved
@egpbos egpbos requested a review from bouweandela December 4, 2024 15:01
bouweandela
bouweandela approved these changes Dec 4, 2024
View reviewed changes
Copy link
Member

@bouweandela bouweandela left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks!

@bouweandela bouweandela merged commit 5327952 into main Dec 4, 2024
2 checks passed
@bouweandela bouweandela deleted the 379_licensing branch December 4, 2024 15:44
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@bouweandela bouweandela bouweandela approved these changes

@c-martinez c-martinez Awaiting requested review from c-martinez

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Clean-up and replace Intellectual property chapter Clean-up and replace Licensing chapter
2 participants
@egpbos @bouweandela