-
Notifications
You must be signed in to change notification settings - Fork 22
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Use env for release and refactor to one file #890
Use env for release and refactor to one file #890
Conversation
@petersalomonsen thank you for your help with the most critical bracket change 🙏🏼 |
@race-of-sloths please include this PR |
@Megha-Dev-19 Thank you for your contribution! Your pull request is now a part of the Race of Sloths! Current status: executed
The average score is 3 @Megha-Dev-19 check out your results on the Race of Sloths Leaderboard! and in the profile What is the Race of SlothsRace of Sloths is a friendly competition where you can participate in challenges and compete with other open-source contributors within your normal workflow For contributors:
For maintainers:
Feel free to check our website for additional details! Bot commands
|
The output from the dry-run diff is quite a lot, are we sure that all of these changes are supposed to be there? For devhub I see removal of empty lines and comments. Is this because bos-workspace is processing the files first? |
@petersalomonsen I think so, their formatting might be different then what we have, because I don't see any added/deleted widgets. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
As long as we're ok with the diff, now when bos-workspace is building, then I think this looks good
@race-of-sloths score 3 |
🌟 Score recorded!@petersalomonsen, thank you for scoring this pull request in the Race of Sloths! |
@petersalomonsen linked the preview for devhub, it looks good. |
✅ PR is finalized!Your contribution is much appreciated with a final score of 3! We would appreciate your feedback or contribution idea that you can submit here |
Devhub preview