Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Use env for release and refactor to one file #890

Merged
merged 7 commits into from
Jul 20, 2024

Conversation

Megha-Dev-19
Copy link
Collaborator

@Megha-Dev-19 Megha-Dev-19 commented Jul 20, 2024

Devhub preview

@Megha-Dev-19 Megha-Dev-19 marked this pull request as ready for review July 20, 2024 19:44
@Megha-Dev-19 Megha-Dev-19 requested a review from Tguntenaar as a code owner July 20, 2024 19:44
@Megha-Dev-19
Copy link
Collaborator Author

@petersalomonsen thank you for your help with the most critical bracket change 🙏🏼

@petersalomonsen
Copy link
Collaborator

@race-of-sloths please include this PR

@race-of-sloths
Copy link

race-of-sloths commented Jul 20, 2024

@Megha-Dev-19 Thank you for your contribution! Your pull request is now a part of the Race of Sloths!
Great job! Usain Bolt jealous of your results!

Shows profile picture for the author of the PR

Current status: executed
Reviewer Score
@petersalomonsen 3

The average score is 3

@Megha-Dev-19 check out your results on the Race of Sloths Leaderboard! and in the profile

What is the Race of Sloths

Race of Sloths is a friendly competition where you can participate in challenges and compete with other open-source contributors within your normal workflow

For contributors:

  • Tag @race-of-sloths inside your pull requests
  • Wait for the maintainer to review and score your pull request
  • Check out your position in the Leaderboard
  • Keep weekly and monthly streaks to reach higher positions
  • Boast your contributions with a dynamic picture of your Profile

For maintainers:

  • Score pull requests that participate in the Race of Sloths
  • Engage contributors with fair scoring and fast responses so they keep their streaks
  • Promote the Race to the point where the Race starts promoting you
  • Grow the community of your contributors

Feel free to check our website for additional details!

Bot commands
  • For contributors
    • Include a PR: @race-of-sloths include to enter the Race with your PR
  • For maintainers:
    • Assign points: @race-of-sloths score [1/2/3/5/8/13] to award points based on your assessment.
    • Reject this PR: @race-of-sloths exclude to send this PR back to the drawing board.
    • Exclude repo: @race-of-sloths pause to stop bot activity in this repo until @race-of-sloths unpause command is called

@petersalomonsen
Copy link
Collaborator

The output from the dry-run diff is quite a lot, are we sure that all of these changes are supposed to be there? For devhub I see removal of empty lines and comments. Is this because bos-workspace is processing the files first?

@Megha-Dev-19
Copy link
Collaborator Author

Megha-Dev-19 commented Jul 20, 2024

@petersalomonsen I think so, their formatting might be different then what we have, because I don't see any added/deleted widgets.
and for infra, there will be changes since earlier we used to import files and copy them, but now we use replacements for constants.
But to be sure, after merging I will test out all to make sure nothing breaks

Copy link
Collaborator

@petersalomonsen petersalomonsen left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

As long as we're ok with the diff, now when bos-workspace is building, then I think this looks good

@petersalomonsen
Copy link
Collaborator

@race-of-sloths score 3

@race-of-sloths
Copy link

🌟 Score recorded!

@petersalomonsen, thank you for scoring this pull request in the Race of Sloths!

@Megha-Dev-19
Copy link
Collaborator Author

@petersalomonsen linked the preview for devhub, it looks good.

@Megha-Dev-19 Megha-Dev-19 merged commit fd3d397 into NEAR-DevHub:main Jul 20, 2024
15 checks passed
@race-of-sloths
Copy link

✅ PR is finalized!

Your contribution is much appreciated with a final score of 3!
You have received 30 Sloth points for this contribution

We would appreciate your feedback or contribution idea that you can submit here

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants