Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add events committee to main branch #843

Merged
merged 38 commits into from
Jul 16, 2024

Conversation

Tguntenaar
Copy link
Collaborator

@Tguntenaar Tguntenaar commented Jun 18, 2024

Resolves #842

As part of issue #777

Check list

  • None of the deployed components to the events-committee.near account change.
  • Github Action that runs the CI for both devhub and events comitee repository.
  • Docs are updated

In the next phase of issue #777 we can unify proposal tests in 1 file. By editing the playwright config projects testMatch cases like this: /(proposal|events)\/.*.spec.js/,. I've skipped it in this PR to closer resamble @Megha-Dev-19 her changes in issue #843.

This PR

  • Adds the code from the events-committee branch into the main branch.
  • Edits proposals.spec for future merging of all proposal tests into a single file instead of 3 seperate once.

I found that the events-commitee is not up-to-date with the main portal so I removed those tests from the proposals. We should make those changes in another PR. (Once this one is merged to chop it in up in smaller bits)

Adding variables

  • NEAR_EVENTS_SOCIAL_ACCOUNT_ID
  • NEAR_EVENTS_SOCIAL_ACCOUNT_PUBLIC_KEY
  • NEAR_EVENTS_SOCIAL_ACCOUNT_PRIVATE_KEY
  • NEAR_EVENTS_SOCIAL_DEPLOY_ID

We will need to update the events-commitee.near contract as well before adding these keys. We don't want to deploy the front end with breaking changes.

Future PR

@petersalomonsen
Copy link
Collaborator

So as we discussed in the call, we will need:

  • A separate copy of the CI workflow targeting the events committee instance ( running the tests that are relevant )
  • A deployment action that does diff ( dry-run ) when not on the main branch

Copy link
Collaborator

@Megha-Dev-19 Megha-Dev-19 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM, but I see some tests are failing.

playwright-tests/tests/blog/blog.spec.js Show resolved Hide resolved
@Tguntenaar
Copy link
Collaborator Author

@race-of-sloths please, include my PR in the race!

@race-of-sloths
Copy link

race-of-sloths commented Jul 13, 2024

@Tguntenaar Thank you for your contribution! Your pull request is now a part of the Race of Sloths!
New Sloth joined the Race! Welcome!

Shows profile picture for the author of the PR

Current status: executed

@Tguntenaar check out your results on the Race of Sloths Leaderboard! and in the profile

What is the Race of Sloths

Race of Sloths is a friendly competition where you can participate in challenges and compete with other open-source contributors within your normal workflow

For contributors:

  • Tag @race-of-sloths inside your pull requests
  • Wait for the maintainer to review and score your pull request
  • Check out your position in the Leaderboard
  • Keep weekly and monthly streaks to reach higher positions
  • Boast your contributions with a dynamic picture of your Profile

For maintainers:

  • Score pull requests that participate in the Race of Sloths
  • Engage contributors with fair scoring and fast responses so they keep their streaks
  • Promote the Race to the point where the Race starts promoting you
  • Grow the community of your contributors

Feel free to check our website for additional details!

Bot commands
  • For contributors
    • Include a PR: @race-of-sloths include to enter the Race with your PR
  • For maintainers:
    • Assign points: @race-of-sloths score [1/2/3/5/8/13] to award points based on your assessment.
    • Reject this PR: @race-of-sloths exclude to send this PR back to the drawing board.
    • Exclude repo: @race-of-sloths pause to stop bot activity in this repo until @race-of-sloths unpause command is called

Copy link
Collaborator Author

@Tguntenaar Tguntenaar left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@Megha-Dev-19 the tests are fixed.

Copy link
Collaborator

@petersalomonsen petersalomonsen left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Great @Tguntenaar Let's get this updated with the main branch, and merged as soon as possible!

@Tguntenaar Tguntenaar merged commit ce199de into NEAR-DevHub:main Jul 16, 2024
13 checks passed
@race-of-sloths
Copy link

🔄 The PR has been merged.

Important

This pull request is a part of the Race of Sloths and has not been scored yet. Scoring will close in 24 hours! 🕰️

@race-of-sloths
Copy link

✅ PR is finalized!

Your contribution is much appreciated with a final score of 0!
You have received 10 (0 base + 10 weekly bonus) Sloth points for this contribution

Another weekly streak completed, well done @Tguntenaar! To keep your weekly streak and get another bonus make pull request next week! Looking forward to see you in race-of-sloths

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Add events-committee.near folder to the BOS workspace
4 participants