-
Notifications
You must be signed in to change notification settings - Fork 22
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Add events committee to main branch #843
Add events committee to main branch #843
Conversation
So as we discussed in the call, we will need:
|
…ture/events-bos-ws
…ture/events-bos-ws
…ture/events-bos-ws
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM, but I see some tests are failing.
@race-of-sloths please, include my PR in the race! |
@Tguntenaar Thank you for your contribution! Your pull request is now a part of the Race of Sloths! Current status: executed@Tguntenaar check out your results on the Race of Sloths Leaderboard! and in the profile What is the Race of SlothsRace of Sloths is a friendly competition where you can participate in challenges and compete with other open-source contributors within your normal workflow For contributors:
For maintainers:
Feel free to check our website for additional details! Bot commands
|
Co-authored-by: Megha <[email protected]>
…feature/events-bos-ws
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
@Megha-Dev-19 the tests are fixed.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Great @Tguntenaar Let's get this updated with the main branch, and merged as soon as possible!
🔄 The PR has been merged.Important This pull request is a part of the Race of Sloths and has not been scored yet. Scoring will close in 24 hours! 🕰️ |
✅ PR is finalized!Your contribution is much appreciated with a final score of 0! Another weekly streak completed, well done @Tguntenaar! To keep your weekly streak and get another bonus make pull request next week! Looking forward to see you in race-of-sloths |
Resolves #842
As part of issue #777
Check list
events-committee.near
account change.In the next phase of issue #777 we can unify proposal tests in 1 file. By editing the playwright config projects testMatch cases like this:
/(proposal|events)\/.*.spec.js/,
. I've skipped it in this PR to closer resamble @Megha-Dev-19 her changes in issue #843.This PR
events-committee
branch into the main branch.I found that the events-commitee is not up-to-date with the main portal so I removed those tests from the proposals. We should make those changes in another PR. (Once this one is merged to chop it in up in smaller bits)
Adding variables
NEAR_EVENTS_SOCIAL_ACCOUNT_ID
NEAR_EVENTS_SOCIAL_ACCOUNT_PUBLIC_KEY
NEAR_EVENTS_SOCIAL_ACCOUNT_PRIVATE_KEY
NEAR_EVENTS_SOCIAL_DEPLOY_ID
We will need to update the events-commitee.near contract as well before adding these keys. We don't want to deploy the front end with breaking changes.
Future PR