-
Notifications
You must be signed in to change notification settings - Fork 22
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Enhance announcements UI #606
Merged
elliotBraem
merged 2 commits into
NEAR-DevHub:develop
from
Megha-Dev-19:update-announcements-UI
Dec 29, 2023
Merged
Enhance announcements UI #606
elliotBraem
merged 2 commits into
NEAR-DevHub:develop
from
Megha-Dev-19:update-announcements-UI
Dec 29, 2023
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Megha-Dev-19
requested review from
ailisp,
frol,
Tguntenaar and
elliotBraem
as code owners
December 27, 2023 16:45
elliotBraem
reviewed
Dec 27, 2023
<div className="w-100" style={{ height: "200px" }} /> | ||
} | ||
src="${REPL_MOB}/widget/MainPage.N.Post" | ||
src="near/widget/Posts.Post" |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Since we want this to work in both mainnet and testnet, could you please use replacements?
${REPL_NEAR}
These replacements are applied on build during the dev script, you can find the value it is replaced with in replacements..json. This allows the code to work across regions
ailisp
pushed a commit
that referenced
this pull request
Jan 18, 2024
* feat: Community Announcements Page (#567) * fix solution action * added community announcements UI * added compose field * minor css updates * use community data instead of dummy data * minor UI updates * add mentions notifications * remove unecessary code * remove hover effect * sets up for contract, adds admin check * fix: Fixed deposit error for grant_write_permissions call to social.near (#563) * add elliot and thomas to CODEOWNERS (#570) * Fix telegram string and array issue (#571) * fix solution action * fix telegram string and array issue * update telegram_handle * fix handle and URL * fix tests * prettier update * fix tests * prettier update * Bugfix/559 error flashes (#569) * fix: flash on home screen * fix: error flash on addon tabs * fix: telegram bug * test fix Tile error flash * fix: catch Tile error flash in every component it is used * remove console.log * Playwright test for input validatiojn (#577) * feature: Added input validation when creating and editing a community (#172) * feature: Added input validation when creating and editing a community * feature: Added input validation when creating and editing a community * feature: Added input validation when creating and editing a community * test: Added test for input validation * fix CI (#581) * fix the test case * Improve robustness of admin moderator tests * Clear draft changes after txn is approved (#588) * remove `onDraftStateChange` from editor * updated changes * move txn hash as props * update draft change --------- Co-authored-by: Elliot Braem <[email protected]> Co-authored-by: T guntenaar <[email protected]> Co-authored-by: Espen Simensen <[email protected]> * replacements for testnet * allow no communities found * attach 2N when creating a community * configures with updated function call * updated announcements UI (#606) Co-authored-by: Elliot Braem <[email protected]> * updates feed * working feed * show preview * fix testnet * Revert "initial typescript support (#468)" This reverts commit 8f28dbb. * Move community Github and Board widgets from devgogigs to devhub (#561) * fix solution action * added required components * remove unnecessary code * add hidden btn * update github configurator * prettier update * fix flash error issue * more improvements * prettier update * refactor code * add comment * added state for when no configurations exists * fix pagination error * handle error * fix map error * fix amount issue * updated UI * decoupled state * remove replace fn * remove title on new column --------- Co-authored-by: T guntenaar <[email protected]> * Kanban board UI enhancement (#620) * fix solution action * added required components * remove unnecessary code * add hidden btn * update github configurator * prettier update * fix flash error issue * more improvements * prettier update * refactor code * add comment * added state for when no configurations exists * fix pagination error * handle error * fix map error * fix amount issue * updated UI * decoupled state * added styling * added table view * updated UI for github * more style updates * added border to table * refactor code * cleaned UI * refactor code * added sorting mechanism * prettier update * reduce border size * remove table and few style updates * fix normalize error and suggestive UI changes * fix .map error * remove table view data * update to devhub.near * fix posts for devgovgigs.near * Points tests to devhub.near rather than devgovgigs.near (#595) * converts devgovgigs to devhub * fix: type * fix feeds * Announcements tests (#639) * added few announcements tests * hide card when no posts exists * add more tests and fix announcements UI * add feed tests * fixed UI * fix community tests * tests * format * working test * format * posts legacy --------- Co-authored-by: Megha-Dev-19 <[email protected]> Co-authored-by: T guntenaar <[email protected]> Co-authored-by: Espen Simensen <[email protected]>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Resolves #605