Community Announcements #603
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
* fix solution action * added community announcements UI * added compose field * minor css updates * use community data instead of dummy data * minor UI updates * add mentions notifications * remove unecessary code * remove hover effect * sets up for contract, adds admin check * fix: Fixed deposit error for grant_write_permissions call to social.near (#563) * add elliot and thomas to CODEOWNERS (#570) * Fix telegram string and array issue (#571) * fix solution action * fix telegram string and array issue * update telegram_handle * fix handle and URL * fix tests * prettier update * fix tests * prettier update * Bugfix/559 error flashes (#569) * fix: flash on home screen * fix: error flash on addon tabs * fix: telegram bug * test fix Tile error flash * fix: catch Tile error flash in every component it is used * remove console.log * Playwright test for input validatiojn (#577) * feature: Added input validation when creating and editing a community (#172) * feature: Added input validation when creating and editing a community * feature: Added input validation when creating and editing a community * feature: Added input validation when creating and editing a community * test: Added test for input validation * fix CI (#581) * fix the test case * Improve robustness of admin moderator tests * Clear draft changes after txn is approved (#588) * remove `onDraftStateChange` from editor * updated changes * move txn hash as props * update draft change --------- Co-authored-by: Elliot Braem <[email protected]> Co-authored-by: T guntenaar <[email protected]> Co-authored-by: Espen Simensen <[email protected]>
3 tasks
13 tasks
|
I realize I still need to complete test coverage, otherwise ready for review |
|
@elliotBraem Great job! |
ailisp
reviewed
Jan 5, 2024
| @@ -61,16 +61,16 @@ return ( | |||
| {renderFaces.map((accountId, i) => ( | |||
| <a | |||
| key={i} | |||
| href={`#/mob.near/widget/ProfilePage?accountId=${accountId}`} | |||
| href={`#/${REPL_MOB}/widget/ProfilePage?accountId=${accountId}`} | |||
There was a problem hiding this comment.
Nice, we can have these testnet widgets now
|
The code looks good, but I'm unable to see the preview. stucking at this screen: 
|
This reverts commit 8f28dbb.
* fix solution action * added required components * remove unnecessary code * add hidden btn * update github configurator * prettier update * fix flash error issue * more improvements * prettier update * refactor code * add comment * added state for when no configurations exists * fix pagination error * handle error * fix map error * fix amount issue * updated UI * decoupled state * remove replace fn * remove title on new column --------- Co-authored-by: T guntenaar <[email protected]>
* fix solution action * added required components * remove unnecessary code * add hidden btn * update github configurator * prettier update * fix flash error issue * more improvements * prettier update * refactor code * add comment * added state for when no configurations exists * fix pagination error * handle error * fix map error * fix amount issue * updated UI * decoupled state * added styling * added table view * updated UI for github * more style updates * added border to table * refactor code * cleaned UI * refactor code * added sorting mechanism * prettier update * reduce border size * remove table and few style updates * fix normalize error and suggestive UI changes * fix .map error * remove table view data
* converts devgovgigs to devhub * fix: type
* added few announcements tests * hide card when no posts exists * add more tests and fix announcements UI * add feed tests * fixed UI * fix community tests
ailisp
approved these changes
Jan 18, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Resolves #540
This pull request holds the full announcements feature with contract changes.
Testnet Preview
Note: If developing, use the command:
TODO
Acceptance Criteria
DevHub community page requirements:
near.org and near social requirements:
Backend storage requirements:
Mockups (See discussion section)
https://www.figma.com/file/6bdpB5IrHztN7E40Rjle1N/Community-Feature%3A-Announcements?type=design&node-id=12%3A6010&mode=design&t=M1jwBsC4NvLrn35p-1
Technical Details
See technical considerations from #540