Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix post-> deposit error #563

Merged
merged 4 commits into from
Dec 13, 2023
Merged

Conversation

Megha-Dev-19
Copy link
Collaborator

Resolves #560
Preview link
For testing, please use an account which hasn't granted devgogigs account permission (for notifications)

I have tested: (using ref from here)

  • add_post
  • edit_post
  • reply -> comment, idea, attestation, solution, sponsorship
  • add_like

Let me know if there is anything missing

@frol
Copy link
Collaborator

frol commented Dec 13, 2023

It used to be 0.1 NEAR deposited with that call to cover the cost of storing the permission data. 0.1 NEAR is too much, but the current 10e5 yoctoNEAR might be too little if it is a fresh account and it had not deposited any tokens to cover storage on social.near contract. @Megha-Dev-19 Let's go with 0.01 NEAR

src/devhub/entity/post/Post.jsx Outdated Show resolved Hide resolved
src/devhub/entity/post/PostEditor.jsx Outdated Show resolved Hide resolved
src/devhub/page/create.jsx Outdated Show resolved Hide resolved
@Megha-Dev-19
Copy link
Collaborator Author

@frol I tested with 0.1 NEAR and 10e5 yoctoNEAR and it works with both
but sure will update it

@frol
Copy link
Collaborator

frol commented Dec 13, 2023

@Megha-Dev-19 I have updated it from the UI, so let's wait for CI and merge it

@frol frol merged commit 4865c46 into NEAR-DevHub:main Dec 13, 2023
4 checks passed
elliotBraem added a commit that referenced this pull request Dec 26, 2023
* fix solution action

* added community announcements UI

* added compose field

* minor css updates

* use community data instead of dummy data

* minor UI updates

* add mentions notifications

* remove unecessary code

* remove hover effect

* sets up for contract, adds admin check

* fix: Fixed deposit error for grant_write_permissions call to social.near (#563)

* add elliot and thomas to CODEOWNERS (#570)

* Fix telegram string and array issue (#571)

* fix solution action

* fix telegram string and array issue

* update telegram_handle

* fix handle and URL

* fix tests

* prettier update

* fix tests

* prettier update

* Bugfix/559 error flashes (#569)

* fix: flash on home screen

* fix: error flash on addon tabs

* fix: telegram bug

* test fix Tile error flash

* fix: catch Tile error flash in every component it is used

* remove console.log

* Playwright test for input validatiojn (#577)

* feature: Added input validation when creating and editing a community (#172)

* feature: Added input validation when creating and editing a community

* feature: Added input validation when creating and editing a community

* feature: Added input validation when creating and editing a community

* test: Added test for input validation

* fix CI (#581)

* fix the test case

* Improve robustness of admin moderator tests

* Clear draft changes after txn is approved (#588)

* remove `onDraftStateChange` from editor

* updated changes

* move txn hash as props

* update draft change

---------

Co-authored-by: Elliot Braem <[email protected]>
Co-authored-by: T guntenaar <[email protected]>
Co-authored-by: Espen Simensen <[email protected]>
@Megha-Dev-19 Megha-Dev-19 deleted the fix-post-error branch January 5, 2024 09:13
ailisp pushed a commit that referenced this pull request Jan 18, 2024
* feat: Community Announcements Page (#567)

* fix solution action

* added community announcements UI

* added compose field

* minor css updates

* use community data instead of dummy data

* minor UI updates

* add mentions notifications

* remove unecessary code

* remove hover effect

* sets up for contract, adds admin check

* fix: Fixed deposit error for grant_write_permissions call to social.near (#563)

* add elliot and thomas to CODEOWNERS (#570)

* Fix telegram string and array issue (#571)

* fix solution action

* fix telegram string and array issue

* update telegram_handle

* fix handle and URL

* fix tests

* prettier update

* fix tests

* prettier update

* Bugfix/559 error flashes (#569)

* fix: flash on home screen

* fix: error flash on addon tabs

* fix: telegram bug

* test fix Tile error flash

* fix: catch Tile error flash in every component it is used

* remove console.log

* Playwright test for input validatiojn (#577)

* feature: Added input validation when creating and editing a community (#172)

* feature: Added input validation when creating and editing a community

* feature: Added input validation when creating and editing a community

* feature: Added input validation when creating and editing a community

* test: Added test for input validation

* fix CI (#581)

* fix the test case

* Improve robustness of admin moderator tests

* Clear draft changes after txn is approved (#588)

* remove `onDraftStateChange` from editor

* updated changes

* move txn hash as props

* update draft change

---------

Co-authored-by: Elliot Braem <[email protected]>
Co-authored-by: T guntenaar <[email protected]>
Co-authored-by: Espen Simensen <[email protected]>

* replacements for testnet

* allow no communities found

* attach 2N when creating a community

* configures with updated function call

* updated announcements UI (#606)

Co-authored-by: Elliot Braem <[email protected]>

* updates feed

* working feed

* show preview

* fix testnet

* Revert "initial typescript support  (#468)"

This reverts commit 8f28dbb.

* Move community Github and Board widgets from devgogigs to devhub (#561)

* fix solution action

* added required components

* remove unnecessary code

* add hidden btn

* update github configurator

* prettier update

* fix flash error issue

* more improvements

* prettier update

* refactor code

* add comment

* added state for when no configurations exists

* fix pagination error

* handle error

* fix map error

* fix amount issue

* updated UI

* decoupled state

* remove replace fn

* remove title on new column

---------

Co-authored-by: T guntenaar <[email protected]>

* Kanban board UI enhancement (#620)

* fix solution action

* added required components

* remove unnecessary code

* add hidden btn

* update github configurator

* prettier update

* fix flash error issue

* more improvements

* prettier update

* refactor code

* add comment

* added state for when no configurations exists

* fix pagination error

* handle error

* fix map error

* fix amount issue

* updated UI

* decoupled state

* added styling

* added table view

* updated UI for github

* more style updates

* added border to table

* refactor code

* cleaned UI

* refactor code

* added sorting mechanism

* prettier update

* reduce border size

* remove table and few style updates

* fix normalize error and suggestive UI changes

* fix .map error

* remove table view data

* update to devhub.near

* fix posts for devgovgigs.near

* Points tests to devhub.near rather than devgovgigs.near (#595)

* converts devgovgigs to devhub

* fix: type

* fix feeds

* Announcements tests (#639)

* added few announcements tests

* hide card when no posts exists

* add more tests and fix announcements UI

* add feed tests

* fixed UI

* fix community tests

* tests

* format

* working test

* format

* posts legacy

---------

Co-authored-by: Megha-Dev-19 <[email protected]>
Co-authored-by: T guntenaar <[email protected]>
Co-authored-by: Espen Simensen <[email protected]>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Unable to Create Solution Post
2 participants