Add sponsorship information in post editor #531
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
ailisp
reviewed
Nov 29, 2023
Can you elaborate? |
I mean the parsing and clean up should only apply to |
ailisp
reviewed
Nov 30, 2023
| supervisor = sponsorMatch ? sponsorMatch[1] : null; | ||
| } | ||
|
|
||
| const seekingFunding = amount !== null || token !== null || supervisor !== null; |
There was a problem hiding this comment.
This can be problematic: if state.postType is not Solution, then amount, token and supervisor is all undefined, and this will be true
There was a problem hiding this comment.
Made these variables null by default to avoid this case
ailisp
reviewed
Nov 30, 2023
| @@ -52,7 +63,7 @@ initState({ | |||
| labelStrings, | |||
| postType, | |||
| name: props.name ?? "", | |||
| description: props.description ?? "", | |||
| description: cleanDescription(props.description) ?? "", | |||
There was a problem hiding this comment.
Also here we want to only cleanDescription if it's a solution type
There was a problem hiding this comment.
Handled this case as well :)
itexpert120
force-pushed
the
original-fields-while-editing
branch
from
ce1a1f8 to
77503f9
Compare
|
rebased to main |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Resolved #469
The cause of this issue was due to the props not being saved with post. The props being passed to the editor didn't exist. So I wrote some regex to extract those props from the description and used them.
For future posts, I recommend saving these props when creating the post.
2023-11-29.06-15-44.mp4