-
Notifications
You must be signed in to change notification settings - Fork 22
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Added notification item code #528
Conversation
@elliotBraem @ailisp |
? "mentioned you in their" | ||
: "???"}{" "} | ||
<a className="fw-bold text-muted" href={href("post", { id: props.post })}> | ||
DevHub post |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Then this <a tag should have
href={to={href({
widgetSrc: "${REPL_DEVHUB}/widget/app",
params: {
page: "post",
id: props.id
},
})}
Although according to the story, the issue here is that for blogs, we should be pointing to blog instead:
to={href({
widgetSrc: "${REPL_DEVHUB}/widget/app",
params: {
page: "blog",
},
})}
But we don't have access to the post type at this moment...
Maybe when we create the notification (author posting the blog), we could pass the postType of where it's coming from?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
The other way could be redirect on the post widget, if it's a blog type, redirect to related blog page
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
yeah we don't know when it's a blog or post notification
@Megha-Dev-19 it's a good start! As per testing, this is something we could do: For near.social, copy and paste the mob.near/widget/NotificationFeed code to local (and any relevant child components) so that we are serving the code locally. It could just be to a temp directory under src/ or something like that. Then, we can create or edit a blog from devhub-test community, adding a mention to your name. We should be able to look at this new notification through our local "forked" notification feed. |
@elliotBraem @ailisp can we merge this PR.? Will update the code further according to contract changes? |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
This looks good to me. @elliotBraem Could you review again? It's currently blocking from your request changes.
Resolves #505