Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

add contributors file #513

Merged
merged 1 commit into from
Nov 28, 2023
Merged

Conversation

DeleMike
Copy link
Contributor

@DeleMike DeleMike commented Nov 27, 2023

Fixes: #506

@DeleMike DeleMike marked this pull request as ready for review November 27, 2023 11:37
@DeleMike DeleMike requested review from ailisp and frol as code owners November 27, 2023 11:37
@DeleMike DeleMike marked this pull request as draft November 27, 2023 11:37
@DeleMike DeleMike marked this pull request as ready for review November 27, 2023 11:49
@DeleMike
Copy link
Contributor Author

@ailisp, please review. what am I missing out?
I followed the All Contributors Docs as a guide.

@ailisp
Copy link
Collaborator

ailisp commented Nov 28, 2023

@allcontributors please add @DeleMike for add contributors file.

Copy link
Contributor

@ailisp

I couldn't determine any contributions to add, did you specify any contributions?
Please make sure to use valid contribution names.

@ailisp
Copy link
Collaborator

ailisp commented Nov 28, 2023

@allcontributors please add @DeleMike for infra

Copy link
Contributor

@ailisp

I've put up a pull request to add @DeleMike! 🎉

@ailisp ailisp merged commit 56c044c into NEAR-DevHub:main Nov 28, 2023
4 checks passed
@ailisp
Copy link
Collaborator

ailisp commented Nov 28, 2023

Thank you @DeleMike !

@ailisp
Copy link
Collaborator

ailisp commented Nov 28, 2023

@all-contributors
please add @nearmax for code.
please add @ailisp for code.
please add @frol for code.
please add @carina-akaia for code.
please add @elliotBraem for code.
please add @itexpert120 for code.
please add @Tguntenaar for code.
please add @petersalomonsen for code.
please add @jaswinder6991 for code.
please add @ori-near for code.
please add @Megha-Dev-19 for code.
please add @espensimensen for code.
please add @DeleMike for code.
please add @frolvanya for code.
please add @ben-jamming-reilly for code.
please add @projectnoa for code.

Copy link
Contributor

@ailisp

We had trouble processing your request. Please try again later.

@ailisp
Copy link
Collaborator

ailisp commented Nov 28, 2023

@all-contributors
please add @nearmax for code.
please add @ailisp for code.
please add @frol for code.
please add @carina-akaia for code.
please add @elliotBraem for code.
please add @itexpert120 for code.
please add @Tguntenaar for code.
please add @petersalomonsen for code.
please add @jaswinder6991 for code.
please add @ori-near for code.
please add @Megha-Dev-19 for code.
please add @espensimensen for code.
please add @DeleMike for code.
please add @frolvanya for code.
please add @ben-jamming-reilly for code.
please add @projectnoa for code.

Copy link
Contributor

@ailisp

We had trouble processing your request. Please try again later.

@ailisp
Copy link
Collaborator

ailisp commented Nov 28, 2023

@all-contributors
please add @nearmax for code.
please add @ailisp for code.
please add @frol for code.
please add @carina-akaia for code.
please add @elliotBraem for code.
please add @itexpert120 for code.
please add @Tguntenaar for code.
please add @petersalomonsen for code.
please add @jaswinder6991 for code.
please add @ori-near for code.

@ailisp
Copy link
Collaborator

ailisp commented Nov 28, 2023

@allcontributors
please add @nearmax for code.
please add @ailisp for code.
please add @frol for code.
please add @carina-akaia for code.
please add @elliotBraem for code.
please add @itexpert120 for code.
please add @Tguntenaar for code.
please add @petersalomonsen for code.
please add @jaswinder6991 for code.
please add @ori-near for code.

Copy link
Contributor

@ailisp

We had trouble processing your request. Please try again later.

@ailisp
Copy link
Collaborator

ailisp commented Nov 28, 2023

@allcontributors
please add @nearmax for code.
please add @ailisp for code.
please add @frol for code.
please add @carina-akaia for code.
please add @elliotBraem for code.

Copy link
Contributor

@ailisp

We had trouble processing your request. Please try again later.

ailisp added a commit that referenced this pull request Nov 28, 2023
ailisp added a commit that referenced this pull request Nov 28, 2023
@ailisp
Copy link
Collaborator

ailisp commented Nov 28, 2023

@all-contributors
please add @nearmax for code.
please add @ailisp for code.
please add @frol for code.
please add @carina-akaia for code.
please add @elliotBraem for code.
please add @itexpert120 for code.
please add @Tguntenaar for code.
please add @petersalomonsen for code.
please add @jaswinder6991 for code.
please add @ori-near for code.
please add @Megha-Dev-19 for code.
please add @espensimensen for code.
please add @DeleMike for code.
please add @frolvanya for code.
please add @ben-jamming-reilly for code.
please add @projectnoa for code.

@ailisp
Copy link
Collaborator

ailisp commented Nov 28, 2023

@DeleMike Thanks for your contribution! Seems allcontributors are quite unreliable, as you can see from this PR it at least have three problems:

  1. It cannot simply read from git history automatically and require manual add contributors
  2. It has problems on recognize the allcontributor configuration after merge your PR, and only work after I revert your PR
  3. Even after that, trying to add multiple contributors it only recorgnize the first, doesn't match the behavior in its doc: https://allcontributors.org/docs/en/bot/usage#using-multiple-lines

Could you please try other alternative tool/service than allcontributors?

Copy link
Contributor

@ailisp

I've put up a pull request to add @nearmax! 🎉

I've put up a pull request to add @ailisp! 🎉

I've put up a pull request to add @frol! 🎉

I've put up a pull request to add @carina-akaia! 🎉

I've put up a pull request to add @elliotBraem! 🎉

I've put up a pull request to add @itexpert120! 🎉

I've put up a pull request to add @Tguntenaar! 🎉

I've put up a pull request to add @petersalomonsen! 🎉

I've put up a pull request to add @jaswinder6991! 🎉

I've put up a pull request to add @ori-near! 🎉

Could not find the user Megha-Dev#/#19 on github.

@DeleMike
Copy link
Contributor Author

@DeleMike Thanks for your contribution! Seems allcontributors are quite unreliable, as you can see from this PR it at least have three problems:

  1. It cannot simply read from git history automatically and require manual add contributors
  2. It has problems on recognize the allcontributor configuration after merge your PR, and only work after I revert your PR
  3. Even after that, trying to add multiple contributors it only recorgnize the first, doesn't match the behavior in its doc: https://allcontributors.org/docs/en/bot/usage#using-multiple-lines

Could you please try other alternative tool/service than allcontributors?

Thanks @ailisp for the updates! do I still go ahead to try another tool/service?

@ailisp
Copy link
Collaborator

ailisp commented Nov 29, 2023

@DeleMike Looks like it's just taking time for all-contributors bot to create PRs for all contributors, and it's one contributor per PR - will cause merge conflict if merge them one by one. I merged on of the PRs, could you please make a PR to all all contributors in one PR manually?

@DeleMike
Copy link
Contributor Author

@ailisp, alright. I am looking into it.

@DeleMike DeleMike mentioned this pull request Nov 29, 2023
@DeleMike DeleMike deleted the add-contributors-section branch November 30, 2023 05:28
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Add a contributors section to our readme
2 participants