Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Improve sort dropdown and communities page layout #503

Closed

Conversation

Megha-Dev-19
Copy link
Collaborator

@Megha-Dev-19 Megha-Dev-19 commented Nov 22, 2023

Resolves #481
Preview link

@Megha-Dev-19 Megha-Dev-19 marked this pull request as ready for review November 23, 2023 05:32
@ailisp
Copy link
Collaborator

ailisp commented Nov 27, 2023

3 column and new sorting looks great~ However I observe a problem when the window is not as wide as full screen but more than the half screen, text is overflowed:

image

There is no such problem if further reduce the window width:
image
image
image

So let's also fix the overflow issue in the first case.

@Megha-Dev-19
Copy link
Collaborator Author

Megha-Dev-19 commented Nov 27, 2023

hey @ailisp
I have fixed it, you can check the preview link, but just fyi, I mostly check the UI for the screen sizes which are actively used (like ipad, mobiles, desktop, laptops), the screen size in which the UI broke was not one of them, so I didn't check it
But thanks for the thorough testing

<option value="a-z">A-Z</option>
<option value="z-a">Z-A</option>
</select>
<div class="dropdown">
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This is a nice select, but needs to be full width

@elliotBraem
Copy link
Contributor

elliotBraem commented Nov 27, 2023

@Megha-Dev-19

There are two PRs for the same story, this one and @itexpert120's #511
This one handles the three column while the other does not

Megha's
Screenshot 2023-11-27 at 11 02 19 AM

Zeeshan's
Screenshot 2023-11-27 at 11 16 14 AM

Zeeshan's has a wide screen Sort bar on mobile while this one does not

Zeeshan's
Screenshot 2023-11-27 at 11 16 46 AM

Megha's
Screenshot 2023-11-27 at 11 04 22 AM

In the codediff, I like how Zeeshan refactored and simplified the Card

@itexpert120
Copy link
Contributor

Ah, mine shows 3 columns on larger screen size.
Also this is old screenshot, can you review my video preview?

@elliotBraem
Copy link
Contributor

@Megha-Dev-19 @itexpert120

Yep, I see now. I was looking at wrong Zeeshan code. Updated and his PR covers all criteria, will merge that one.

Thanks tho @Megha-Dev-19 :)

@Megha-Dev-19 Megha-Dev-19 deleted the fix-communities-ui branch December 13, 2023 13:27
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Improve communities page rendering & sorting
4 participants