Fix tagging #492
Fix tagging #492
Conversation
src/devhub/page/create.jsx
Outdated
| @@ -10,7 +10,7 @@ const AutoComplete = styled.div` | |||
| `; | |||
|
|
|||
| function textareaInputHandler(value) { | |||
| const showAccountAutocomplete = /@[\w][^\s]*$/.test(value); | |||
| const showAccountAutocomplete = /(^|\s)@/.test(value); | |||
There was a problem hiding this comment.
Will this make autocomplete bar always showup, as @ will always exist?
There was a problem hiding this comment.
no actually not
it works when there is a whitespace before @ or if it's in the beginning of the text
|
Thanks @Megha-Dev-19 ! This seems like a right fix, but I'm not sure. Could you provide a preview link or a short screen recording to ensure two issues reported by @ori-near is fixed? |
|
Hey @ailisp yeah sure, attaching the screen recording here. Screen.Recording.2023-11-21.at.10.58.15.mov |
@Megha-Dev-19 Exactly for preview, you can deploy it on your account and then share the link in the PR |
|
@Tguntenaar here is the preview link |
|
@Megha-Dev-19 Thanks for your response, I tried myself. The issue 1 is fixed, but not the issue 2, see Ori's video in #487 from 00:40, when you try |
|
hey @ailisp you're right, I will check this |
|
Looks perfect now! Thank you! |
|
Looks so good, thank you! |
Resolves #487