Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Create admin page with ability to control featured communities #309

Conversation

carina-akaia
Copy link
Contributor

@carina-akaia carina-akaia commented Oct 16, 2023

Closes #275

@carina-akaia carina-akaia self-assigned this Oct 16, 2023
@petersalomonsen
Copy link
Collaborator

Is there a preview environment for this? And tests that shows what this PR does?

@carina-akaia
Copy link
Contributor Author

Is there a preview environment for this? And tests that shows what this PR does?

The link to the demo environment is published within the original ticket

Speaking of tests, I'm not sure if it possible to properly cover the implementation with them, given that page link and content will show up only for accounts with DevHub moderator role. Do you think it makes sense to test the access rejection case?

@petersalomonsen
Copy link
Collaborator

Is there a preview environment for this? And tests that shows what this PR does?

The link to the demo environment is published within the original ticket

Speaking of tests, I'm not sure if it possible to properly cover the implementation with them, given that page link and content will show up only for accounts with DevHub moderator role. Do you think it makes sense to test the access rejection case?

In playwright you can manipulate localstorage, and to test what happens for the moderator role, you can simply set the account to theori.near like shown in the screenshot below. So you can test both access rejection, and what happens if you have access.

image

@Tguntenaar
Copy link
Collaborator

@carina-akaia shouldn't we build this in the new root? I was about the start with issue #315, I can move it over but let me know what you prefer.

src/gigs-board/components/molecule/button.jsx Outdated Show resolved Hide resolved
src/gigs-board/components/molecule/tile.jsx Outdated Show resolved Hide resolved
src/gigs-board/pages/admin.jsx Outdated Show resolved Hide resolved
src/devhub/page/admin.jsx Show resolved Hide resolved
src/devhub/page/admin.jsx Outdated Show resolved Hide resolved
src/devhub/page/admin.jsx Show resolved Hide resolved
@carina-akaia carina-akaia marked this pull request as ready for review November 16, 2023 18:17
@Tguntenaar Tguntenaar closed this Nov 21, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

[Communities] Give DevHub moderators the ability to set Featured Communities on homepage (FRONT END)
4 participants