-
Notifications
You must be signed in to change notification settings - Fork 22
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Establish new root and refactor communities #306
Merged
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
3 tasks
* Implement server side search * case insensitive search on content * add search test
elliotBraem
force-pushed
the
refactor/root
branch
2 times, most recently
from
October 18, 2023 00:49
4a6da93
to
d29232f
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Pull request regarding #294
Unblocks:
#253 - new community addon framework
#175 - telegram plugin
#268 - blog plugin
#267 - wiki plugin
#265 - github plugin
#266 - kanban plugin
Sets the stage for:
#303 - New DevHub homepage
#295 - Updates to layout and header
See a preview here and navigate to and around the Communities. (A full migration for Feed has not yet been complete, will wait for approval first)
How does it work?
It starts with a new namespace (DevHub) and a new root (DevHub.App)
Within this new root, we simulate a sort-of React Router (for BOS) that checks for a "page" prop and determines the page from this:
And we define our Theme and Layout:
Rather than merge this to mainnet, I'd like if #305 could be approved and this could be merged to testnet first.
Merging 305 will also unblock #301 so there can be more clean code in this refactor.