Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Feature #50 Hurricane Matthew: Add WRF plotting to METplus run #66

Merged
merged 15 commits into from
Oct 15, 2024

Conversation

georgemccabe
Copy link
Contributor

@georgemccabe georgemccabe commented Oct 11, 2024

Pull Request Testing

  • Describe testing already performed for these changes:

Ran through updated instructions on casper and confirmed that plots were generated

  • Recommend testing for the reviewer(s) to perform, including the location of input datasets, and any additional instructions:

Run through updated instructions from feature branch and ensure that plots are generated successfully:
https://i-wrf.readthedocs.io/en/feature-50_add_plots_to_metplus/Users_Guide/matthewjetstream.html

  • Do these changes include sufficient documentation updates, ensuring that no errors or warnings exist in the build of the documentation? [Yes]

Once we confirm that these steps work, we should update the instructions to include info on how to view the images

  • Do these changes include sufficient testing updates? [Yes]

  • Will this PR result in changes to the test suite? [N/A]

    If yes, describe the new output and/or changes to the existing output:

  • Please complete this pull request review by 10/16/2024.

Pull Request Checklist

  • Review the source issue metadata (required labels, projects, and milestone).
  • Complete the PR definition above.
  • Ensure the PR title matches the feature or bugfix branch name.
  • Define the PR metadata, as permissions allow.
    Select: Reviewer(s)
    Select: Organization level software support Project or Repository level development cycle Project
    Select: Milestone as the version that will include these changes
  • After submitting the PR, select Development issue with the original issue number.
  • After the PR is approved, merge your changes. If permissions do not allow this, request that the reviewer do the merge.
  • Close the linked issue and delete your feature or bugfix branch from GitHub.

Copy link
Collaborator

@Trumbore Trumbore left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I tested the new setup on Jetstream and it worked fine. I only have one request, which is to update the "tail" output of the WRF run, as it now includes lines related to the zlev and plev output files. Here is the tail output from my test, which you can use:

Timing for main: time 2016-10-07_23:50:00 on domain 1: 0.25548 elapsed seconds
Timing for main: time 2016-10-07_23:52:30 on domain 1: 0.25495 elapsed seconds
Timing for main: time 2016-10-07_23:55:00 on domain 1: 0.25066 elapsed seconds
Timing for main: time 2016-10-07_23:57:30 on domain 1: 0.25231 elapsed seconds
Timing for main: time 2016-10-08_00:00:00 on domain 1: 0.25795 elapsed seconds
Timing for Writing wrfout_d01_2016-10-08_00:00:00 for domain 1: 0.68666 elapsed seconds
Timing for Writing wrfout_zlev_d01_2016-10-08_00:00:00 for domain 1: 0.47411 elapsed seconds
Timing for Writing wrfout_plev_d01_2016-10-08_00:00:00 for domain 1: 0.47619 elapsed seconds
Timing for Writing restart for domain 1: 1.54598 elapsed seconds
d01 2016-10-08_00:00:00 wrf: SUCCESS COMPLETE WRF

@georgemccabe georgemccabe requested a review from Trumbore October 15, 2024 14:55
@georgemccabe
Copy link
Contributor Author

Thanks for the feedback, @Trumbore. I just made the change you suggested and re-requested your review.

Copy link
Collaborator

@Trumbore Trumbore left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks!

@georgemccabe georgemccabe merged commit fab3623 into main Oct 15, 2024
3 checks passed
@georgemccabe georgemccabe deleted the feature/50_add_plots_to_metplus branch October 15, 2024 15:22
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants