Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
dewtemp_trh #101
dewtemp_trh #101
Changes from all commits
ae89d49
9545b31
56e2982
bb450a8
26f2c71
84bc121
32ac550
37ec397
2397ad3
f5b768c
94d8272
6ef5c5a
8c14267
c70bbd0
0c01ee7
9cf166a
79b83ae
10b1f9b
e217890
b2d8e52
ebd7e9a
8fd0d74
4155cba
d649234
f9fc52a
b7a43a4
22c7c1f
fd00698
e272322
f4be3a6
d2ef995
File filter
Filter by extension
Conversations
Jump to
There are no files selected for viewing
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Just wondering if we want to keep the "Grab and Go" label if all of the code is within this section. I interpreted it more as a way to differentiate the fast code from the minutiae - but this notebook is very streamlined.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
That's a good point, I think it is currently worth keeping for consistency with the templates and in this case, I was planning on seeing if any other meteorology functions were short enough to put in one notebook with this one (i.e. daylight)
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Should this point to the NCL receipt notebook?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Actually none of them do, so I'm pretty sure this is correct as is. Are NCL receipts only visible from the GitHub repository (for those really LOOKING for them)?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
You can get to the receipts from the website, though it's not obvious.
If you scroll down to the end of the NCL index, there's a link to the receipts page
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Ahh I think I used to see it was there when the table was shorter, but now that it's so long we might want a better solution (of course not in this PR).