Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

ufs/dev "omnibus" changes from 11/2024-02/2025 #1109

Merged
merged 236 commits into from
Feb 6, 2025

Conversation

grantfirl
Copy link
Collaborator

@grantfirl grantfirl commented Feb 4, 2025

This PR catches the NCAR:main branch up with changes from the ufs-community:ufs/dev branch since Thanksgiving 2024. All changes have previously been reviewed via PRs into ufs-community:ufs/dev and previously tested using UFS RTs. This PR (together with NCAR/ccpp-scm#558) has been regression tested using SCM RTs. The results are in the SCM PR.

Associated ufs/dev PRs:

AndersJensen-NOAA and others added 30 commits December 7, 2023 14:01
…nd it will be consistent with convective precipitation"
…entrations.F90 due to passing in PI as variable
[production/RRFS.v1] physics updates for RRFS.v1 code freeze
…_alloc_RRFS

[production/RRFS.v1] Fix 'check all' with 0-size allocations
…into feature/lnd_iau

* 'feature/lnd_iau' of https://github.com/tsga/ccpp-physics:
  correct the meta file
  correctly convert from flashes per five minutes to flashes per minute
  In physics/Interstitials/UFS_SCM_NEPTUNE/maximum_hourly_diagnostics.F90, scale lightning threat from flashes per 5 minutes to flashes per minute to match units in metadata
  In physics/Interstitials/UFS_SCM_NEPTUNE/maximum_hourly_diagnostics.meta: change units 'flashes 5 min-1' to 'flashes min-1' and update long name to make clear this is per 5 minutes
Copy link
Collaborator

@climbfuji climbfuji left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I reviewed all of the PRs that make up this extensive set of changes. Thanks for taking care of all these updates.

@grantfirl grantfirl requested review from scrasmussen and hertneky and removed request for scrasmussen February 6, 2025 19:34
Copy link
Member

@scrasmussen scrasmussen left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Double checked the changes and things look good in the SCM, thanks!

Copy link
Collaborator

@hertneky hertneky left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Everything looks good with PRs included here.

@grantfirl grantfirl merged commit ae65555 into NCAR:main Feb 6, 2025
3 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.