Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

--V flag option does not work when attempting to generate core IM #871

Closed
wants to merge 5 commits into from

Conversation

jshughes
Copy link
Collaborator

The -V flag does not work when attempting to generate core IM.

🗒️ Summary

The -V flag for specifying that LDDTool should use a prior version of the IM did not work when generating the Core schemas. The code was changed to allow the -V option for Core and LDD processing.

The WriteDOMDocBook.java was also modified. References to static variables were removed and replaced with get method calls. There was also significant cleanup of dated code.

⚙️ Test Data and/or Report

The regressions tests for comparing current and prior results from LDDTool process will test some of the current changes. A subsequent PR is planned to add additional tests.

♻️ Related Issues

Resolves #859

DOMInfoModel.getMasterDOMAttrArr(),
DMDocument.getMasterPDSSchemaFileDefn(),
DMDocument.getMasterNameSpaceIdNCLC() to remove some dependencies on
static variables.
@jshughes jshughes self-assigned this Jan 31, 2025
@jordanpadams jordanpadams changed the title V flag option does not work when attempting to generate core IM --V flag option does not work when attempting to generate core IM Feb 3, 2025
@jordanpadams
Copy link
Member

@jshughes whenever you see the Secret Detection failing, it means something was introduced that may be some sort of username/password/email information that was unintended.

Screenshot 2025-02-04 at 9 03 22 AM

In that case, you should install the detect-secrets app, re-run the baseline and audit, and commit the new .secrets.baseline to the repository. Instructions are here:

https://github.com/NASA-PDS/nasa-pds.github.io/wiki/Git-and-Github-Guide#detect-secrets

The audit will basically just go through and have you review that all the detected "secrets" are acceptable. If not, you know you introduced something you should not have, and should be removed and re-run.

I went through this for you here, and updated the baseline.

Copy link

sonarqubecloud bot commented Feb 5, 2025

@jordanpadams
Copy link
Member

Closing for #873

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

-V flag does not work when attempting to generate core IM
2 participants