-
Notifications
You must be signed in to change notification settings - Fork 0
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
fix: add mdx generation #188
Conversation
Workflow StatusStarting workflow... View action run Collection Publication Status
Collection Publication Status
|
The script, when run locally, generates a file with:
|
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I ran this locally and it works as expected. I think we might be able to parse a bit more from the dataset-config json and maybe add some more hints in the rendered MDX about properties that need to be updated. I think the only change that we actually need to add here is the shebang in the python file
"sourceParams": { | ||
"assets": asset_id, | ||
"resampling_method": "bilinear", | ||
"colormap_name": "wistia", | ||
"rescale": "0,365", | ||
"maxzoom": 4, | ||
}, |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
"sourceParams": { | |
"assets": asset_id, | |
"resampling_method": "bilinear", | |
"colormap_name": "wistia", | |
"rescale": "0,365", | |
"maxzoom": 4, | |
}, |
I think we should check and see if the dashboard is ready to use renders params instead of sourceParams and leave this out entirely?
Co-authored-by: Alexandra Kirk <[email protected]>
Co-authored-by: Alexandra Kirk <[email protected]>
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
My other comments were just for discussion. This is ready to go
Issue
#182