perf(RequestParser): optimization (#204)

* perf(Utils): optimize toLowerString * perf(Request): use const reference * perf: remove unnecessary temporary objects * refactor(RequestParser): add const qualifier * perf(RequestParser): optimize functions * wip: perf * fix(RequestParser): fix stupid logic
MyLittleWebServer · Jul 31, 2023 · 9114019 · 9114019
1 parent 0652c85
commit 9114019
Show file tree

Hide file tree

Showing 8 changed files with 219 additions and 141 deletions.
diff --git a/srcs/clients/client/src/Client.cpp b/srcs/clients/client/src/Client.cpp
@@ -113,7 +113,7 @@ void Client::parseRequest(short port) {
   }
   if (_request.isExpect100()) {
     _state = EXPECT_CONTINUE;
-    std::string temp = std::string(toLowerString(_recvBuff));
+    std::string temp = toLowerString(_recvBuff);
     size_t pos = temp.find("expect");
     size_t end = temp.find("\r\n", pos);
     if (pos == std::string::npos) return;

diff --git a/srcs/clients/request/include/IRequest.hpp b/srcs/clients/request/include/IRequest.hpp
@@ -25,9 +25,10 @@ class IRequest {
   virtual std::map<std::string, std::string> &getHeaderFields(void) = 0;
   virtual IServerConfig *getMatchedServer(void) const = 0;
 
-  virtual const std::string getHeaderField(std::string key) const = 0;
+  virtual const std::string &getHeaderField(const std::string &key) const = 0;
   virtual void clear(void) = 0;
-  virtual void setHeaderField(std::string key, std::string value) = 0;
+  virtual void setHeaderField(const std::string &key,
+                              const std::string &value) = 0;
 
   virtual const bool &isParsed(void) const = 0;
   virtual const bool &isCgi(void) const = 0;

diff --git a/srcs/clients/request/include/Request.hpp b/srcs/clients/request/include/Request.hpp
@@ -62,8 +62,8 @@ class Request : public IRequest {
   const std::string &getCgiPath(void) const;
   const std::string &getBody(void) const;
   const std::string &getQueryString(void) const;
-  const std::string getHeaderField(std::string key) const;
-  void setHeaderField(std::string key, std::string value);
+  const std::string &getHeaderField(const std::string &key) const;
+  void setHeaderField(const std::string &key, const std::string &value);
 
   size_t getContentLength(void) const;
   const std::map<std::string, std::string> &getQueryStringElements(void) const;

diff --git a/srcs/clients/request/request_parser/include/RequestParser.hpp b/srcs/clients/request/request_parser/include/RequestParser.hpp
@@ -40,11 +40,12 @@ class RequestParser : public IRequestParser {
   void setConnectionClose(RequestDts& dts);
   void validateDuplicateInvalidHeaders(std::string key, RequestDts& dts);
   void validateContentLengthHeader(RequestDts& dts);
-  void validateHeaderKey(std::string& key, RequestDts& dts);
+  void validateHeaderKey(const std::string& key, RequestDts& dts);
   void validateHostHeader(short port, RequestDts& dts);
   void ValidateContentEncoding(RequestDts& dts);
-  void hostHeaderNameCheck(std::string hostName, RequestDts& dts);
-  void hostHeaderportCheck(short port, std::string portName, RequestDts& dts);
+  void hostHeaderNameCheck(const std::string& hostName, RequestDts& dts);
+  void hostHeaderportCheck(short port, const std::string& portName,
+                           RequestDts& dts);
 
   void removeNotAscii(std::string& field);