-
Notifications
You must be signed in to change notification settings - Fork 155
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[TASK] Polish the git rebasing section in CONTRIBUTING.md
#1387
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
All changes seem like improvements to me.
I wrote this section based on rebasing as a collaborator. I think the instructions for contributors (with PRs on a fork, particularly the examples) would vary from this, and that this section really needs to be written with that target audience in mind. I'll create a ticket for it...
@@ -142,20 +142,20 @@ To rebase a feature branch to the latest `main`: | |||
1. Make sure that your local copy of the repository has the most up-to-date | |||
revisions of `main` (this is important, otherwise you may end up rebasing to | |||
an older base point): | |||
```sh | |||
git checkout main | |||
```bash |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
This was missed in #1366.
```sh | ||
git checkout main | ||
```bash | ||
git switch main |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
New in Git 2.23 - additional separate commands added to declutter the overloaded functionality of checkout
. Since this was released more than 5 years ago, I think it's safe to assume most people will have a version which supports this command.
```sh | ||
git add *.* | ||
```bash | ||
git add . |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
From what I understand, this means that git
will do the file system traversal, rather than the shell, which is probably better due to being OS-independent.
|
Part of #1360