Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[TASK] Integrate composer-normalize in the static analysis CI job #1363

Merged
merged 1 commit into from
Nov 5, 2024
Merged

[TASK] Integrate composer-normalize in the static analysis CI job #1363

merged 1 commit into from
Nov 5, 2024

Conversation

oliverklee
Copy link
Contributor

No description provided.

@oliverklee oliverklee added this to the 8.0.0 milestone Nov 5, 2024
@oliverklee oliverklee requested a review from JakeQZ November 5, 2024 11:54
@oliverklee oliverklee self-assigned this Nov 5, 2024
@coveralls
Copy link

Coverage Status

coverage: 97.062%. remained the same
when pulling 8ab51a8 on task/move-normalize-in-ci
into af3207f on main.

JakeQZ
JakeQZ approved these changes Nov 5, 2024
View reviewed changes
Copy link
Contributor

@JakeQZ JakeQZ left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Neat. Does no harm I think to also install the Composer dependencies even though the normalize command uses a PHIVE dependency, and would also make it easier to change the normalize command to use a Composer dependency instead, should we ever want to.

@JakeQZ JakeQZ merged commit 77afd30 into main Nov 5, 2024
28 checks passed
@JakeQZ JakeQZ deleted the task/move-normalize-in-ci branch November 5, 2024 12:47
oliverklee added a commit to MyIntervals/PHP-CSS-Parser that referenced this pull request Nov 5, 2024
@oliverklee
[TASK] Prepare for non-PHP-checks on CI
b3248d5 
Following this change in Emogrifier and preparing for the addition
of composer-normalize:

MyIntervals/emogrifier#1363
@oliverklee oliverklee mentioned this pull request Nov 5, 2024
Merged
JakeQZ pushed a commit to MyIntervals/PHP-CSS-Parser that referenced this pull request Nov 5, 2024
@oliverklee
[TASK] Prepare for non-PHP-checks on CI (#763)
89cfeaf 
Following this change in Emogrifier and preparing for the addition
of composer-normalize:

MyIntervals/emogrifier#1363
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@JakeQZ JakeQZ JakeQZ approved these changes

Assignees

@oliverklee oliverklee

Labels
cleanup
Projects
None yet
Milestone
8.0.0
Development

Successfully merging this pull request may close these issues.
3 participants
@oliverklee @coveralls @JakeQZ