Issue #202 add flame life + bomb movement #218
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
fschlatt
changed the title
fschlatt
force-pushed
the
flame_life
branch
2 times, most recently
from
c77a202 to
2c49d70
Compare
cinjon
reviewed
Jun 9, 2019
cinjon
reviewed
Jun 9, 2019
|
looks pretty good, although not sure why the need for the +1? |
|
lgtm! thanks :). |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
As requested in issue #202 adds further array to observation of an agent.
flame_lifeticks down like the bombs except it starts at 3.EDIT: also added bomb movement direction in as further map of ints where bomb movement is int in action space
EDIT 2: when squashing commits
make_flame_mapfunction got copied twice. The second force push removed that error.EDIT 3: the third force push were two spelling errors I found in the documentation. My bad!