Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Bug fixes and cleanup #1817

Merged
merged 9 commits into from
Dec 11, 2023
Merged

Bug fixes and cleanup #1817

merged 9 commits into from
Dec 11, 2023

Conversation

MrTJP
Copy link
Owner

@MrTJP MrTJP commented Dec 10, 2023

  • Add package-info.java to all package directories and enforce everything being Nonnull by default.
  • Clean entire code-base to abide by new nullability rules. Mark all nullable fields as @Nullable
  • Fixed a few faces in Frame model having 5 vertices by removing duplicates. CCL's object loader will try to quadulate non quads, leading to quads that have duplicate vests. This causes normal calculation to not work. Without normals, re-tracing the frame model gives a crash.
  • Dropped usage of deprecated methods in CBM
  • Add a visual grid overlay effect when in edit mode in the IC Workbench to better let the user know that compilation is required.
  • Create and publish a separate API jar. Instructions also added in README. (Closes Create a separate artifact for the API #1512)
  • Add setting in IC Workbench to automatically run compilation when the design changes. This feature is available until the design reaches a configurable number of tiles (default 20)
  • Minor logging cleanup

@MrTJP MrTJP merged commit 9a26071 into main Dec 11, 2023
2 checks passed
@MrTJP MrTJP deleted the patch-1208 branch December 11, 2023 03:52
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Create a separate artifact for the API
1 participant