Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

#327: Package form-data replaced to formdata-node for add esm support #341

Conversation

MrRefactoring
Copy link
Owner

Closes #327

- Implemented `Buffer` to `File` conversion for attachment uploads.
- Added `attachment.mimeType` an optional property.
- Added automatic MIME type detection based on file extensions.
… v18.x.x by using `File` from `formdata-node`.

- Enhanced documentation with TSDoc and examples for better clarity.
@MrRefactoring MrRefactoring merged commit e050109 into release/v4.0.4 Jan 3, 2025
8 checks passed
@MrRefactoring MrRefactoring deleted the feature/#327-form-data-replaced-to-formdata-node-for-esm-support branch January 3, 2025 22:30
@MrRefactoring MrRefactoring mentioned this pull request Jan 3, 2025
@MrRefactoring MrRefactoring added this to the v4.0.4 milestone Jan 3, 2025
@MrRefactoring MrRefactoring added the enhancement Denotes a suggestion or request aimed at improving or adding new features to the project. label Jan 3, 2025
MrRefactoring added a commit that referenced this pull request Jan 4, 2025
* #327: Package `form-data` replaced to `formdata-node` for add esm support (#341)

* #327: Package `form-data` replaced to `formdata-node` for add esm support

* #327: Add `Buffer` type support using `formdata-node` package

- Implemented `Buffer` to `File` conversion for attachment uploads.
- Added `attachment.mimeType` an optional property.
- Added automatic MIME type detection based on file extensions.

* #327: Fixed the issue with the absence of the `File` class in Node.js v18.x.x by using `File` from `formdata-node`.

- Enhanced documentation with TSDoc and examples for better clarity.

* #320: Fix tree shaking mechanism and remove circular dependencies (#343)

- Improved the tree shaking process to ensure unused code is properly eliminated across the entire library.
- Refactored the codebase to resolve circular dependencies, improving tree shaking and maintainability.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement Denotes a suggestion or request aimed at improving or adding new features to the project.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

TypeError: form_data_1.default is not a constructor when adding attachment
1 participant