Swap form-data for formdata-node (#333)

The newer library better supports modules and is written in TypeScript. The FormData interface is a drop-in replacement except for getHeaders(), but that didn't do anything useful, so it can be dropped. Closes #327 Signed-off-by: Matyáš Kroupa <[email protected]> Co-authored-by: Matyáš Kroupa <[email protected]> Co-authored-by: Vladislav Tupikin <[email protected]>
MrRefactoring · Jan 2, 2025 · a650eb1 · a650eb1
1 parent df8e9d2
commit a650eb1
Show file tree

Hide file tree

Showing 5 changed files with 15 additions and 11 deletions.
diff --git a/package-lock.json b/package-lock.json
diff --git a/package.json b/package.json
@@ -71,8 +71,8 @@
     "vitest": "^2.1.8"
   },
   "dependencies": {
-    "axios": "^1.7.9",
-    "form-data": "^4.0.1",
-    "tslib": "^2.8.1"
+    "axios": "^1.7.7",
+    "formdata-node": "^6.0.3",
+    "tslib": "^2.7.0"
   }
 }
diff --git a/src/serviceDesk/serviceDesk.ts b/src/serviceDesk/serviceDesk.ts
@@ -1,4 +1,4 @@
-import * as FormData from 'form-data';
+import { FormData } from 'formdata-node';
 import * as Models from './models';
 import * as Parameters from './parameters';
 import { Callback } from '../callback';
@@ -124,7 +124,6 @@ export class ServiceDesk {
       headers: {
         'X-Atlassian-Token': 'no-check',
         'Content-Type': 'multipart/form-data',
-        ...formData.getHeaders?.(),
       },
       data: formData,
     };

diff --git a/src/version2/issueAttachments.ts b/src/version2/issueAttachments.ts
@@ -1,5 +1,4 @@
-// @ts-expect-error Wrong form data typings
-import FormData from 'form-data';
+import { FormData } from 'formdata-node';
 import * as Models from './models';
 import * as Parameters from './parameters';
 import { Callback } from '../callback';
@@ -434,7 +433,6 @@ export class IssueAttachments {
       headers: {
         'X-Atlassian-Token': 'no-check',
         'Content-Type': 'multipart/form-data',
-        ...formData.getHeaders?.(),
       },
       data: formData,
       maxBodyLength: Infinity,

diff --git a/src/version3/issueAttachments.ts b/src/version3/issueAttachments.ts
@@ -1,5 +1,4 @@
-// @ts-expect-error Wrong form data typings
-import FormData from 'form-data';
+import { FormData } from 'formdata-node';
 import * as Models from './models';
 import * as Parameters from './parameters';
 import { Callback } from '../callback';
@@ -434,7 +433,6 @@ export class IssueAttachments {
       headers: {
         'X-Atlassian-Token': 'no-check',
         'Content-Type': 'multipart/form-data',
-        ...formData.getHeaders?.(),
       },
       data: formData,
       maxBodyLength: Infinity,