Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

chore: add PR and issue templates #115

Merged
merged 3 commits into from
Jul 17, 2024
Merged

chore: add PR and issue templates #115

merged 3 commits into from
Jul 17, 2024

Conversation

fpgmaas
Copy link
Collaborator

@fpgmaas fpgmaas commented Jul 17, 2024

No description provided.

@fpgmaas fpgmaas requested a review from SemyonSinchenko July 17, 2024 06:00
SemyonSinchenko
SemyonSinchenko reviewed Jul 17, 2024
View reviewed changes
Copy link
Collaborator

@SemyonSinchenko SemyonSinchenko left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

All is good, thank you! One small thing: may we add a row to the end of templates with a checkbox and something like I'm willing to make pull-request? In the future we may add an auto-assignment if the checkbox is marked.

@fpgmaas
Copy link
Collaborator Author

fpgmaas commented Jul 17, 2024

All is good, thank you! One small thing: may we add a row to the end of templates with a checkbox and something like I'm willing to make pull-request? In the future we may add an auto-assignment if the checkbox is marked.

Good idea, done!

SemyonSinchenko
SemyonSinchenko approved these changes Jul 17, 2024
View reviewed changes
Copy link
Collaborator

@SemyonSinchenko SemyonSinchenko left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM, thank you!

@SemyonSinchenko SemyonSinchenko merged commit f3180e6 into MrPowers:main Jul 17, 2024
7 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@SemyonSinchenko SemyonSinchenko SemyonSinchenko approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@fpgmaas @SemyonSinchenko