Fix a bug where parameters in the Read/Write nodes could stay visible…

… when changing file type
MrKepzie · Oct 11, 2016 · 11e2967 · 11e2967
1 parent 2f35bee
commit 11e2967
Show file tree

Hide file tree

Showing 2 changed files with 9 additions and 9 deletions.
diff --git a/Engine/ReadNode.cpp b/Engine/ReadNode.cpp
@@ -407,12 +407,12 @@ ReadNodePrivate::cloneGenericKnobs()
                 } else {
                     (*it2)->clone( serializedKnob.get() );
                 }
-                (*it2)->setSecret( serializedKnob->getIsSecret() );
-                if ( (*it2)->getDimension() == serializedKnob->getDimension() ) {
+                //(*it2)->setSecret( serializedKnob->getIsSecret() );
+                /*if ( (*it2)->getDimension() == serializedKnob->getDimension() ) {
                     for (int i = 0; i < (*it2)->getDimension(); ++i) {
                         (*it2)->setEnabled( i, serializedKnob->isEnabled(i) );
                     }
-                }
+                }*/
 
                 break;
             }
@@ -473,10 +473,10 @@ ReadNodePrivate::destroyReadNode()
             bool isGeneric = isGenericKnob( (*it)->getName(), &mustSerializeKnob );
             if (!isGeneric || mustSerializeKnob) {
 
-                if (!isGeneric && !(*it)->getDefaultIsSecret()) {
+               /* if (!isGeneric && !(*it)->getDefaultIsSecret()) {
                     // Don't save the secret state otherwise some knobs could be invisible when cloning the serialization even if we change format
                     (*it)->setSecret(false);
-                }
+                }*/
 
                 boost::shared_ptr<KnobSerialization> s( new KnobSerialization(*it) );
                 serialized.push_back(s);

diff --git a/Engine/WriteNode.cpp b/Engine/WriteNode.cpp
@@ -375,12 +375,12 @@ WriteNodePrivate::cloneGenericKnobs()
                 } else {
                     (*it2)->clone( serializedKnob.get() );
                 }
-                (*it2)->setSecret( serializedKnob->getIsSecret() );
+                /*(*it2)->setSecret( serializedKnob->getIsSecret() );
                 if ( (*it2)->getDimension() == serializedKnob->getDimension() ) {
                     for (int i = 0; i < (*it2)->getDimension(); ++i) {
                         (*it2)->setEnabled( i, serializedKnob->isEnabled(i) );
                     }
-                }
+                }*/
 
                 break;
             }
@@ -441,10 +441,10 @@ WriteNodePrivate::destroyWriteNode()
             bool isGeneric = isGenericKnob( (*it)->getName(), &mustSerializeKnob );
             if (!isGeneric || mustSerializeKnob) {
 
-                if (!isGeneric && !(*it)->getDefaultIsSecret()) {
+                /*if (!isGeneric && !(*it)->getDefaultIsSecret()) {
                     // Don't save the secret state otherwise some knobs could be invisible when cloning the serialization even if we change format
                     (*it)->setSecret(false);
-                }
+                }*/
                 boost::shared_ptr<KnobSerialization> s( new KnobSerialization(*it) );
                 serialized.push_back(s);
             }