🔧 Refactor key modifier handling in Keycorder #675
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Collaborator
SenpaiHunters
commented
Jan 21, 2025
SenpaiHunters
commented
- Updated the logic to retrieve current modifiers by using a mapping of modifier flags to key codes.
- Filtered out trigger keys from the current modifiers to ensure they do not exceed the key limit.
- Fixes a bug where adding a trigger key with an arrow would cause the FN key to also be added.
- Renamed variables for clarity and improved code readability.
- Updated the logic to retrieve current modifiers by using a mapping of modifier flags to key codes. - Filtered out trigger keys from the current modifiers to ensure they do not exceed the key limit. - Fixes a bug where adding a trigger key with an arrow would cause the FN key to also be added. - Renamed variables for clarity and improved code readability.
4 tasks
MrKai77
approved these changes
Jan 22, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.