chore: add methods for making D2Connection hashable and comparable …
#17
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…to easily ensure uniqueness if needed chore: add methods for making `D2Connection` hashable and comparable to easily ensure uniqueness if needed
MrBlenny
approved these changes
May 3, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
I didn't find any instructions on how you'd like to receive contributions (if at all), but it's worth a shot. :)
This one adds
__hash__and__eq__methods to allow comparing connections without casting them to string first.PS. Thanks for making this library, I'm using it in my project https://github.com/netsatan/specifipy as a dependency.