fastmail#472 fixed bug where deletion of selected text was no longer …

…possible due to startContainer.isContentEditable being undefined on text nodes
MrAlexand0r · Jan 9, 2025 · d59fff8 · d59fff8
1 parent 819960f
commit d59fff8
Show file tree

Hide file tree

Showing 2 changed files with 3 additions and 3 deletions.
diff --git a/source/node/Node.ts b/source/node/Node.ts
@@ -43,8 +43,8 @@ const areAlike = (
             node.nodeName !== 'A' &&
             node.className === node2.className &&
             node.style.cssText === node2.style.cssText &&
-            (node as HTMLElement).isContentEditable &&
-            (node2 as HTMLElement).isContentEditable
+            node.isContentEditable &&
+            node2.isContentEditable
         );
     }
     return true;

diff --git a/source/range/Boundaries.ts b/source/range/Boundaries.ts
@@ -158,7 +158,7 @@ const moveRangeBoundariesUpTree = (
 
     range.setStart(startContainer, startOffset);
 
-    if (!(startContainer as HTMLElement).isContentEditable) {
+    if (startContainer instanceof HTMLElement && !startContainer.isContentEditable) {
         range.setStart(endContainer, endOffset);
     }