Improve Bugzilla access denied message #435
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## master #435 +/- ##
==========================================
- Coverage 99.60% 99.60% -0.01%
==========================================
Files 52 52
Lines 5582 5559 -23
==========================================
- Hits 5560 5537 -23
Misses 22 22 ☔ View full report in Codecov by Sentry. |
tysmith
force-pushed
the
update-bugzilla
branch
2 times, most recently
from
24738c1 to
4294587
Compare
jschwartzentruber
approved these changes
May 27, 2024
grizzly/common/bugzilla.py
Outdated
| @@ -127,6 +127,12 @@ def load(cls, bug_id: int) -> Optional["BugzillaBug"]: | |||
| return cls(bugzilla.get(bug_id)) | |||
| except BugsyException as exc: | |||
| LOG.error("%s", exc.msg) | |||
| # Access Denied | |||
| if api_key is None and exc.code == 102: | |||
| LOG.info( | |||
There was a problem hiding this comment.
Should be warning?
There was a problem hiding this comment.
The exception message is descriptive and printed with LOG.error(). This is a suggestion for local users.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.