-
Notifications
You must be signed in to change notification settings - Fork 0
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
FUZ-19A - Improve testcase handling in Bugzilla Template #24
base: master
Are you sure you want to change the base?
Conversation
No Taskcluster jobs started for this pull requestThe |
This PR is estimated to cost between 25 and 50 credits. |
1 similar comment
This PR is estimated to cost between 25 and 50 credits. |
6312157
to
e08051e
Compare
This PR is estimated to cost between 25 and 50 credits. |
143aba5
to
2a0ddae
Compare
Contains changes from #18 |
dd8972c
to
c782b7a
Compare
Fixes #19 |
file_name: this.filenameWithExtension, | ||
summary: "Detailed Crash Information", | ||
content_type: "text/plain", | ||
content_type: this.fileMimetype, |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
This attachment should remain named crash_data.txt
and text/plain
. The testcase filename and mime-type belong only to the testcase attachment.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
This is noted, would update this.
file_name: filenameWithExtension.value, | ||
summary: "Detailed Crash Information", | ||
content_type: "text/plain", | ||
content_type: fileMimetype.value, |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
This attachment should remain named crash_data.txt
and text/plain
. The testcase filename and mime-type belong only to the testcase attachment.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
This is noted, would update this.
The demo looks great. This will need to be rebased, but the diff against fdb57cc looks good to me, besides the comments above. |
What is in the PR?
This PR improves how we handle testcase attachments in Bugzilla bug reports. Here's what changed:
{{testcase_attachment}}
CLIENT DEMO VIDEO: https://www.loom.com/share/af46fd8c8bc140509f71ff5f76ca7c52?sid=22c7c360-64bb-4f5e-81db-13c29da909f7