Generified collision mesh generation #595
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
#593 has been merged, ready for conflict resolution and finalizing 👍 Does this likely clash any with the updated mesh work for mazes in the GSOC project? I guess that might relate more to just arranging meshes rather than generating them. Mazes are still pretty whacky on collision shapes but I think that's pre-existing. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
This PR generifies collision mesh creation. Rather than needing to create a separate system for each type of
Bodywith a new instance ofCollisionMeshLoader, the newCollisionMeshBuilderSystemhandles allBodycreation.The
BodyLinkedcomponent has two new fields - one for the JSON path to the mesh data, and another for the schema file that details how the data is laid out. When an entity has aBodyLinkedcomponent, the system will build aBodyusing the mesh data when it receives aGenerateBodyEvent(which will happen at the next tick).Testing
Shoot the testing asteroid (the golden asteroid visible on startup). The projectile should still collide with it, so the asteroid should be destroyed.
Outstanding Work
This PR will cause merge conflicts with #593. I'm marking this as a draft until after that PR is merged, and then I'll address the conflicts.