Right condition to check if premium is accepted

[grunch]

Summary by CodeRabbit

• Bug Fixes
  • Improved order validation logic to ensure more robust parameter checking
  • Updated error message routing for more accurate reporting

The changes enhance the order processing mechanism by refining parameter validation and error handling.

[coderabbitai]

Walkthrough

The pull request modifies the order processing logic in the src/app/order.rs file. The changes introduce a new amount variable that captures the order's amount value when non-zero. The validation logic has been updated to require amount, premium, and fiat_amount to be present before sending an error message. Additionally, the error message's recipient has been changed from &event.sender to &event.rumor.pubkey, altering the error reporting context.

Changes

File	Change Summary
src/app/order.rs	- Added new amount variable capturing non-zero order amount - Modified validation condition to check amount, premium, and fiat_amount - Updated error message recipient from &event.sender to &event.rumor.pubkey

Possibly related PRs

• Hot fix updating order on fiat-sent #423: Modifications to the fiat_sent_action function involving order variable handling and error processing logic

Poem

🐰 A rabbit's tale of order's might,
Validations dancing left and right,
Amount and premium in perfect sync,
Error messages now swiftly link,
Code's ballet, a computational delight! 🧮

---

📜 Recent review details

Configuration used: CodeRabbit UI
Review profile: CHILL
Plan: Pro

📥 Commits

Reviewing files that changed from the base of the PR and between ca361b4 and 880129e.

📒 Files selected for processing (1)

• src/app/order.rs (1 hunks)

⏰ Context from checks skipped due to timeout of 90000ms (1)

• GitHub Check: tests

🔇 Additional comments (1)

src/app/order.rs (1)

85-85: Verify consistency of error message recipient change.

The error message recipient has been changed from event.sender to event.rumor.pubkey. This change appears in multiple error handling calls.

Let's verify if this change is consistent with the error handling pattern across the codebase:

✅ Verification successful

Error message recipient change is consistent with codebase patterns

The change from event.sender to event.rumor.pubkey aligns with the established error handling pattern across the codebase, where event.rumor.pubkey is consistently used as the destination for error messages.

🏁 Scripts executed

The following scripts were executed for the analysis:

Script:

#!/bin/bash
# Search for other instances of send_cant_do_msg to verify recipient parameter usage
rg "send_cant_do_msg\(" -A 5

# Search for other usages of event.sender vs event.rumor.pubkey
rg "event\.(sender|rumor\.pubkey)" --type rust

Length of output: 20727

---

Thank you for using CodeRabbit. We offer it for free to the OSS community and would appreciate your support in helping us grow. If you find it useful, would you consider giving us a shout-out on your favorite social media?

❤️ Share

• X
• Mastodon
• Reddit
• LinkedIn

🪧 Tips

Chat

There are 3 ways to chat with CodeRabbit:

• Review comments: Directly reply to a review comment made by CodeRabbit. Example:
  • I pushed a fix in commit <commit_id>, please review it.
  • Generate unit testing code for this file.
  • Open a follow-up GitHub issue for this discussion.
• Files and specific lines of code (under the "Files changed" tab): Tag @coderabbitai in a new review comment at the desired location with your query. Examples:
  • @coderabbitai generate unit testing code for this file.
  • @coderabbitai modularize this function.
• PR comments: Tag @coderabbitai in a new PR comment to ask questions about the PR branch. For the best results, please provide a very specific query, as very limited context is provided in this mode. Examples:
  • @coderabbitai gather interesting stats about this repository and render them as a table. Additionally, render a pie chart showing the language distribution in the codebase.
  • @coderabbitai read src/utils.ts and generate unit testing code.
  • @coderabbitai read the files in the src/scheduler package and generate a class diagram using mermaid and a README in the markdown format.
  • @coderabbitai help me debug CodeRabbit configuration file.

Note: Be mindful of the bot's finite context window. It's strongly recommended to break down tasks such as reading entire modules into smaller chunks. For a focused discussion, use review comments to chat about specific files and their changes, instead of using the PR comments.

CodeRabbit Commands (Invoked using PR comments)

• @coderabbitai pause to pause the reviews on a PR.
• @coderabbitai resume to resume the paused reviews.
• @coderabbitai review to trigger an incremental review. This is useful when automatic reviews are disabled for the repository.
• @coderabbitai full review to do a full review from scratch and review all the files again.
• @coderabbitai summary to regenerate the summary of the PR.
• @coderabbitai generate docstrings to generate docstrings for this PR. (Beta)
• @coderabbitai resolve resolve all the CodeRabbit review comments.
• @coderabbitai configuration to show the current CodeRabbit configuration for the repository.
• @coderabbitai help to get help.

Other keywords and placeholders

• Add @coderabbitai ignore anywhere in the PR description to prevent this PR from being reviewed.
• Add @coderabbitai summary to generate the high-level summary at a specific location in the PR description.
• Add @coderabbitai anywhere in the PR title to generate the title automatically.

CodeRabbit Configuration File (.coderabbit.yaml)

• You can programmatically configure CodeRabbit by adding a .coderabbit.yaml file to the root of your repository.
• Please see the configuration documentation for more information.
• If your editor has YAML language server enabled, you can add the path at the top of this file to enable auto-completion and validation: # yaml-language-server: $schema=https://coderabbit.ai/integrations/schema.v2.json

Documentation and Community

• Visit our Documentation for detailed information on how to use CodeRabbit.
• Join our Discord Community to get help, request features, and share feedback.
• Follow us on X/Twitter for updates and announcements.