Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Use PublishJson from outside the crate #8

Closed
wants to merge 2 commits into from

Conversation

siemtim-dev
Copy link
Contributor

PublishJson is not constructible from outside the crate because the fields are only pub(crate). I asses a PublishJson::new() function to allow the construction of PublishJson from outside the crate.

@Mossop
Copy link
Owner

Mossop commented Jan 7, 2025

Topic::with_json exists for constructing this, is there a need for the additional method?

@siemtim-dev
Copy link
Contributor Author

Ah, that's right. It is a bit unintuitive as a Method of Topic. I will close this MR.

@siemtim-dev siemtim-dev closed this Jan 9, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants