Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update Gadget:wikieditor-highlight with CodeMirror 6 #392

Merged
merged 11 commits into from
Jan 17, 2024
Merged

Conversation

bhsd-harry
Copy link
Contributor

因为用到了import()语法,不确定能否正常运行。有办法先搞一个测试用gadget吗?

@lovelyCARDINAL
Copy link
Member

可以,新建一个小工具,配置权限为techedit吧

@AnnAngela
Copy link
Member

AnnAngela commented Jan 13, 2024

可以先本地试试tsc,看看输出是啥

@bhsd-harry bhsd-harry marked this pull request as draft January 13, 2024 14:56
@bhsd-harry bhsd-harry marked this pull request as ready for review January 17, 2024 06:33
@lovelyCARDINAL lovelyCARDINAL merged commit cf11a65 into MoegirlPediaInterfaceAdmins:master Jan 17, 2024
7 checks passed
@bhsd-harry bhsd-harry deleted the patch-1 branch January 17, 2024 17:03
AnnAngela pushed a commit that referenced this pull request Jan 18, 2024
* Update MediaWiki:Gadget-wikieditor-highlight.js using CodeMirror 6

* fix(MediaWiki:Gadget-wikieditor-highlight.js): dynamic import

* feat(Gadget-wikieditor-highlight): Update definition.yaml

* Delete MediaWiki:Gadget-wikieditor-highlight.css

* feat(wikieditor-highlight): default addons

* fix(libCachedCode): ES module

* refactor(Gadget-wikieditor-highlight.js): localStorage fallback

* Update MediaWiki:Gadget-wikieditor-highlight.js

* fix(wikieditor-highlight): avoid reusing global CodeMirror

* delete temporary gadget
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
Archived in project
Development

Successfully merging this pull request may close these issues.

3 participants