Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[WIP] Paging Refactor #606

Closed
wants to merge 11 commits into from
Closed

[WIP] Paging Refactor #606

wants to merge 11 commits into from

Conversation

matt-ramotar
Copy link
Collaborator

Closes # (Issue number)

Description

What changes are you introducing with this PR? Please include motivation and context.

Type of Change

  • Bug fix (non-breaking change which fixes an issue)
  • New feature (non-breaking change which adds functionality)
  • Breaking change (fix or feature that would cause existing functionality to not work as expected)
  • This change requires a documentation update

Test Plan

How has this been tested? Please describe the tests that you added to verify your changes.

Checklist:

Before submitting your PR, please review and check all of the following:

  • I have performed a self-review of my own code
  • I have commented my code, particularly in hard-to-understand areas
  • I have made corresponding changes to the documentation
  • My changes generate no new warnings
  • I have added tests that prove my change is effective
  • New and existing unit tests pass locally with my changes

Additional Notes:

Add any other information about the PR here.

Signed-off-by: mramotar_dbx <[email protected]>
Signed-off-by: mramotar_dbx <[email protected]>
Signed-off-by: mramotar_dbx <[email protected]>
Signed-off-by: mramotar_dbx <[email protected]>
Signed-off-by: mramotar_dbx <[email protected]>
Signed-off-by: mramotar_dbx <[email protected]>
Signed-off-by: mramotar_dbx <[email protected]>
Signed-off-by: mramotar_dbx <[email protected]>
Signed-off-by: mramotar_dbx <[email protected]>
Signed-off-by: mramotar_dbx <[email protected]>
Signed-off-by: mramotar <[email protected]>

Refactor

Signed-off-by: mramotar <[email protected]>

Integrate anchor position

Signed-off-by: mramotar <[email protected]>

Refactor

Signed-off-by: mramotar <[email protected]>

Rename

Signed-off-by: mramotar <[email protected]>

Separate responsibilities

Signed-off-by: mramotar <[email protected]>

Add DefaultPagingStreamProvider

Signed-off-by: mramotar <[email protected]>

Add compose

Signed-off-by: mramotar <[email protected]>
@matt-ramotar matt-ramotar deleted the matt-ramotar/pager branch March 16, 2024 17:51
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
Status: Done
Development

Successfully merging this pull request may close these issues.

1 participant