Custom Boards - 2nd core can be used on rp2040 #320
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Firmware for this pull request: |
|
Firmware for this pull request: |
|
Firmware for this pull request: |
|
Firmware for this pull request: |
|
Firmware for this pull request: |
DocMoebiuz
reviewed
May 23, 2024
| uint8_t command, stepper; | ||
| int32_t param1, param2; | ||
|
|
||
| while (1) { |
There was a problem hiding this comment.
while (true) would be prettier.
|
i think the description of this PR requires a bit more documentation on the actual scope and how to use it.
|
|
Board and firmware folder for this pull request: |
|
Board and firmware folder for this pull request: |
|
Board and firmware folder for this pull request: |
DocMoebiuz
approved these changes
May 27, 2024
DocMoebiuz
changed the title
DocMoebiuz
changed the title
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description of changes
On Picos the 2nd core is used to run the
set()function of the community devices.With this change setting a new value to a community device will not lead to missed input events even if the
set()function needs much more time.The
FreeRTOSlib is used to initialize and run the 2nd core of a Pico. Data from the 1st core to the 2nd core is transferred by using the build infifo. Once all data is received the 2nd core calls theset()function of the community device.To activate this feature only one define within
custom.platformio.iniis required. Once-DUSE_2ND_COREis set, this feature is enabled. If it is not set or even not available, the 2nd core of the pico is not used and everything is like before. So it's fully backward compatible, the 2nd core will not be used as long as the above mentioned flag is not set.Fixes #319