Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

update glob to v9 #69

Merged
merged 1 commit into from
Jul 6, 2024
Merged

update glob to v9 #69

merged 1 commit into from
Jul 6, 2024

Conversation

chromy
Copy link
Contributor

@chromy chromy commented Jun 22, 2024

Description

Update glob to v9

Motivation and Context

Installing ospec currently shows the following warnings:

 WARN  deprecated [email protected]: Glob versions prior to v9 are no longer supported
 WARN  deprecated [email protected]: This module is not supported, and leaks memory. Do not use it. Check out lru-cache if you want a good and tested way to coalesce async requests by a key value, which is much more comprehensive and powerful.

See also:

How Has This Been Tested?

Types of changes

  • Bug fix (non-breaking change which fixes an issue)
  • New feature (non-breaking change which adds functionality)
  • Breaking change (fix or feature that would cause existing functionality to change)
  • Documentation change

Checklist:

  • My code follows the code style of this project.
  • My change requires a change to the documentation.
  • I have updated the documentation accordingly.
  • I have read all applicable contributing documents.
  • I have added tests to cover my changes.
  • [ x] All new and existing tests passed.
  • I have updated the change log (if applicable).

@chromy chromy requested a review from pygy as a code owner June 22, 2024 18:11
@dead-claudia
Copy link
Member

Have you tested this yet? I see the box isn't checked in the initial comment.

@chromy
Copy link
Contributor Author

chromy commented Jun 24, 2024

I had not - but I have now and I did discover and fix an issue, thanks! :)

[snip]
...took 524 ms
[ metadata + v5 API + esm + pnpm]
...took 730 ms
[ metadata + v5 API + esm + yarn]
...took 636 ms
––––––
All 10333 assertions passed

log-after.txt
log-before.txt

@dead-claudia
Copy link
Member

@chromy Did you attach the right log file? The "before" file doesn't show failures?

@dead-claudia
Copy link
Member

Ignore the CI run. #70

@chromy
Copy link
Contributor Author

chromy commented Jul 5, 2024

@dead-claudia Ah by before I meant running the tests at HEAD (610b2c3) and after was with my latest changes (bfcc9f3), sorry that was not clear.

@dead-claudia
Copy link
Member

@dead-claudia Ah by before I meant running the tests at HEAD (610b2c3) and after was with my latest changes (bfcc9f3), sorry that was not clear.

@chromy Oh, okay. That makes more sense.

@dead-claudia dead-claudia merged commit dbce1af into MithrilJS:main Jul 6, 2024
0 of 23 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants