Merge pull request #250 from Mirantis/provcheck

Check Provisioner state before saving and provisioning new Cluster

kqueen/blueprints/api/test_cluster.py

@@ -226,6 +226,30 @@ def fake_provision(self, *args, **kwargs):
 
         assert response.status_code == 500
 
+    @pytest.mark.parametrize('provisioner_state', [
+        config.get('PROVISIONER_UNKNOWN_STATE'),
+        config.get('PROVISIONER_ERROR_STATE')
+    ])
+    def test_provision_failed_with_unhealthy_provisioner(self, provisioner, user, provisioner_state):
+        provisioner.state = provisioner_state
+        provisioner.save(check_status=False)
+        user.save()
+
+        post_data = {
+            'name': 'Testing cluster',
+            'provisioner': 'Provisioner:{}'.format(provisioner.id),
+            'owner': 'User:{}'.format(user.id)
+        }
+
+        response = self.client.post(
+            url_for('api.cluster_create'),
+            data=json.dumps(post_data),
+            headers=self.auth_header,
+            content_type='application/json',
+        )
+
+        assert response.status_code == 500
+
     def test_return_400_missing_json(self):
         response = self.client.post(
             url_for('api.cluster_create'),

kqueen/blueprints/api/views.py

@@ -110,6 +110,13 @@ def get_content(self, *args, **kwargs):
 class CreateCluster(CreateView):
     object_class = Cluster
 
+    def save_object(self):
+        if self.obj.provisioner.state != config.get('PROVISIONER_OK_STATE'):
+            msg = 'Cannot create cluster with malfunctioning Provisioner'
+            logger.error('Provisioning failed: {}'.format(msg))
+            abort(500, description=msg)
+        return super().save_object()
+
     def after_save(self):
         # start provisioning
         prov_status, prov_msg = self.obj.engine.provision()

kqueen/conftest.py

@@ -49,6 +49,7 @@ def cluster():
         engine='kqueen.engines.ManualEngine',
         owner=_user
     )
+    prov.state = config.get('PROVISIONER_OK_STATE')
     prov.save(check_status=False)
 
     create_kwargs = {

kqueen/engines/test_manual.py

@@ -1,5 +1,6 @@
 from .manual import ManualEngine
 from flask import url_for
+from kqueen.config import current_config
 from kqueen.conftest import auth_header
 from kqueen.conftest import user
 from kqueen.models import Cluster
@@ -9,6 +10,7 @@
 import pytest
 import yaml
 
+config = current_config()
 KUBECONFIG = yaml.load(open('kubeconfig_localhost', 'r').read())
 CLUSTER_METADATA = {
     'minion_count': 10,
@@ -33,6 +35,7 @@ def setup(self):
         }
 
         prov = Provisioner(_user.namespace, **create_kwargs_provisioner)
+        prov.state = config.get('PROVISIONER_OK_STATE')
         prov.save(check_status=False)
 
         self.create_kwargs_cluster = {