Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

feat: Add faiss #19

Merged
merged 19 commits into from
Nov 17, 2024
Merged

feat: Add faiss #19

merged 19 commits into from
Nov 17, 2024

Conversation

Pringled
Copy link
Member

No description provided.

@Pringled Pringled marked this pull request as ready for review November 15, 2024 09:42
@Pringled Pringled requested a review from stephantul November 15, 2024 09:42
@codecov-commenter
Copy link

codecov-commenter commented Nov 15, 2024 •
edited
Loading

Codecov Report

Attention: Patch coverage is 96.85535% with 5 lines in your changes missing coverage. Please review.

Files with missing lines Patch % Lines
vicinity/backends/faiss.py 95.96% 5 Missing ⚠️
Files with missing lines Coverage Δ
tests/conftest.py 100.00% <100.00%> (ø)
tests/test_vicinity.py 100.00% <100.00%> (ø)
vicinity/backends/__init__.py 100.00% <100.00%> (ø)
vicinity/datatypes.py 100.00% <100.00%> (ø)
vicinity/backends/faiss.py 95.96% <95.96%> (ø)

stephantul
stephantul approved these changes Nov 16, 2024
View reviewed changes
Copy link
Member

@stephantul stephantul left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM, some small changes/comments

tests/conftest.py Outdated Show resolved Hide resolved
tests/conftest.py Show resolved Hide resolved
tests/test_vicinity.py Outdated Show resolved Hide resolved
tests/test_vicinity.py Outdated Show resolved Hide resolved
vicinity/backends/faiss.py Outdated Show resolved Hide resolved
vicinity/backends/faiss.py Show resolved Hide resolved
vicinity/backends/faiss.py Outdated Show resolved Hide resolved
vicinity/backends/faiss.py Outdated Show resolved Hide resolved
vicinity/backends/faiss.py Show resolved Hide resolved
@Pringled Pringled merged commit 529eb5f into main Nov 17, 2024
5 checks passed
@Pringled Pringled deleted the add-faiss branch November 24, 2024 18:22
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@stephantul stephantul stephantul approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@Pringled @codecov-commenter @stephantul