Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[release_7] update latest api version and fix constructor #58

Merged
merged 1 commit into from
Jan 31, 2024

Conversation

xJuvi
Copy link
Contributor

@xJuvi xJuvi commented Jan 31, 2024

Update the API to the latest dev version and fix constructor loading for ILIAS7 support. (fixes #45 )

@xJuvi xJuvi mentioned this pull request Jan 31, 2024
@waddahadel
Copy link

Hey @xJuvi ,

sorry for the late reply, this fix is valid, there is some slight mistake with the setDuration method in the CreateMeetingParameters, I was getting this error ilErrorHandling::{closure}:50 0 Argument 1 passed to BigBlueButton\Parameters\CreateMeetingParameters::setDuration() must be of the type int, null given just changed the expected type to ?int to allow more flexibility, I will merge and just fix it afterwards, nothing serious really, thanks for the help, I'm still a junior with PHP and ILIAS in particular, hope to get better with time

@waddahadel waddahadel merged commit 5e30a0d into Minervis-GmbH:release_7 Jan 31, 2024
3 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants