Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add Bestemshe variant #37

Merged
merged 1 commit into from
Sep 12, 2024
Merged

Conversation

msomatt
Copy link
Member

@msomatt msomatt commented Sep 12, 2024

No description provided.

@@ -1033,6 +1033,29 @@ export class Togyzkumalak extends Chess {
}
}

export class Bestemshe extends Chess {
// TODO - move into own class and have variant family
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Actually I think you should be able to start splitting code like described in the comment if you want, now that the build system is there

Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

The whole of this file could do with a refactor. I've raised: https://linear.app/playstrategy/issue/PLA-987/refactor-variantts-in-stratops to consider this

@msomatt msomatt merged commit d4b8f02 into master Sep 12, 2024
4 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants