Do not use magic config file in integration tests #16441
Conversation
|
!ci-build-me |
dkijania
force-pushed
the
dkijania/do_not_use_magic_config_in_int_tests
branch
from
e538f3b to
83711be
Compare
|
!ci-build-me |
|
!ci-nightly-me |
| ( "entrypoint.sh" | ||
| , {|#!/bin/bash | ||
| # This file is auto-generated by the local integration test framework. | ||
| # |
There was a problem hiding this comment.
I wonder, could we just provide more overrides in integration test code instead of crude removal. P.S. in a med-term we want to get rid of this config discovery in a docker image.
There was a problem hiding this comment.
I still suggest to explore the path of overriding the proof component in the integration test config instead of modification of a file below.
dkijania
force-pushed
the
dkijania/do_not_use_magic_config_in_int_tests
branch
from
9e0c3f1 to
cd75cbd
Compare
|
!ci-build-me |
|
!ci-nightly-me |
| ( "entrypoint.sh" | ||
| , {|#!/bin/bash | ||
| # This file is auto-generated by the local integration test framework. | ||
| # |
There was a problem hiding this comment.
I still suggest to explore the path of overriding the proof component in the integration test config instead of modification of a file below.
|
Oh. I misunderstood you! Will work on altering config in int tests and keeping prod config intact |
dkijania
force-pushed
the
dkijania/do_not_use_magic_config_in_int_tests
branch
from
cd75cbd to
e71d6a7
Compare
|
!ci-nightly-me |
|
!ci-build-me |
|
!ci-build-me |
Modifies code which formats
entrypoint.shfile for deamon image which is used in integration tests through mina daemon puppeteer. It removes/var/lib/coda/config_{comit_hash}.jsonat the beginning as it is used as one of config layer by default. See https://github.com/MinaProtocol/mina/blob/compatible/src/lib/runtime_config/runtime_config.ml#L1728 for more details.As a result, first layer of configs is config file from genesis_ledgers/{network}.json. In berkeley case it does not have any influence since berkeley config file has only content which is completely replaced by next layer (which is created by test executive). For other networks like devnet or mainnet it is more problematic as configs contains fork section, which then prevents node to produce any block. This is blocking us from using any other image (devnet for instance)