Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Remove hardcoded values for zk_rows and num_chunks in Pickles code #16092

Merged
merged 6 commits into from
Sep 24, 2024

Conversation

querolita
Copy link
Member

@querolita querolita commented Sep 19, 2024

This is part of the investigation of the chunking bug in Pickles and o1js (RFCs here and here).

Partially addresses o1-labs/o1js#1806

Explain your changes:

  • Substitute hardcoded values of 3 for zk_rows for a variables called zk_rows_by_default, and likewise for 1 and num_chunks.
  • This is to facilitate debugging and reduce error proneness.

Explain how you tested your changes:

  • It only contains cosmetic changes.
  • There must still be a few places in our codebase, because the chunking tests in o1js still read 3 always.

Checklist:

  • Dependency versions are unchanged
    • Notify Velocity team if dependencies must change in CI
  • Modified the current draft of release notes with details on what is completed or incomplete within this project
  • Document code purpose, how to use it
    • Mention expected invariants, implicit constraints
  • Tests were added for the new behavior
    • Document test purpose, significance of failures
    • Test names should reflect their purpose
  • All tests pass (CI will check this if you didn't)
  • Serialized types are in stable-versioned modules
  • Does this close issues? List them
  • Closes #0000

Copy link
Member

@volhovm volhovm left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

src/lib/pickles/plonk_checks/plonk_checks.mli Outdated Show resolved Hide resolved
@querolita
Copy link
Member Author

!ci-build-me

@querolita querolita changed the title Remove hardcoded values for zk_rows and num_chunnks in Pickles code Remove hardcoded values for zk_rows and num_chunks in Pickles code Sep 23, 2024
@querolita querolita requested review from a team as code owners September 23, 2024 15:24
@querolita querolita changed the base branch from chunking/zkrows_fix to develop September 23, 2024 15:25
@querolita querolita force-pushed the chunking/default_zkrows branch from c00e104 to db8641c Compare September 23, 2024 15:27
@querolita querolita changed the base branch from develop to chunking/zkrows_fix September 23, 2024 15:27
@querolita
Copy link
Member Author

!ci-build-me

@querolita querolita merged commit 3e83054 into chunking/zkrows_fix Sep 24, 2024
1 check passed
@querolita querolita deleted the chunking/default_zkrows branch September 24, 2024 09:18
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants