-
Notifications
You must be signed in to change notification settings - Fork 548
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Remove hardcoded values for zk_rows
and num_chunks
in Pickles code
#16092
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
volhovm
approved these changes
Sep 19, 2024
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM
!ci-build-me |
querolita
changed the title
Remove hardcoded values for
Remove hardcoded values for Sep 23, 2024
zk_rows
and num_chunnks
in Pickles codezk_rows
and num_chunks
in Pickles code
querolita
force-pushed
the
chunking/zkrows_fix
branch
from
September 23, 2024 15:24
b6bdcb1
to
3319804
Compare
querolita
force-pushed
the
chunking/default_zkrows
branch
from
September 23, 2024 15:27
c00e104
to
db8641c
Compare
!ci-build-me |
7 tasks
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This is part of the investigation of the chunking bug in Pickles and o1js (RFCs here and here).
Partially addresses o1-labs/o1js#1806
Explain your changes:
3
forzk_rows
for a variables calledzk_rows_by_default
, and likewise for1
andnum_chunks
.Explain how you tested your changes:
o1js
still read3
always.Checklist: