-
Notifications
You must be signed in to change notification settings - Fork 550
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[Test-executive] Download coverage files from pods #12727
Closed
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
!ci-build-me |
!ci-build-me |
acba2fd
to
4b92064
Compare
1fe0be2
to
ae78a64
Compare
b4ad445
to
ac04f7b
Compare
f734d36
to
7cb5c05
Compare
5 tasks
260da4a
to
b43c6b7
Compare
993055e
to
271cfc6
Compare
271cfc6
to
ea56ada
Compare
…each service (seed,producers,snark-workers). move config and gcloud folders under root in help. As a result those folder will be persisted
ea56ada
to
9a5a877
Compare
9a5a877
to
4e25018
Compare
…ished. Added first step to unit tests for pushing partial coverage data
…enabled. Fix or excluded coverage for broken source files
4e25018
to
b1c219a
Compare
|
1 similar comment
|
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Explain your changes:
This PR is an attempt to gather code coverage report from e2e-tests (rather than unit tests) using bisect_ppx.
Idea is to build mina with
--instrument-with
parameter and then prepare docker which can be use in for example test_executive run.Explain how you tested your changes:
Currently i tested it locally using some simple command like
mina client status
and verifying that coverage report is produced.Then i tried to use multiple packages of mina and start small local network. However there is a problem with setting custom location for bisect artifact. Solution from guide https://github.com/aantron/bisect_ppx/blob/master/doc/advanced.md#environment-variables does not work. And bisect coverage files are put in main
mina
folder . I tried both environment variable and:Checklist:
--instrument-with bisect_ppx
argument