Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[Test-executive] Download coverage files from pods #12727

Closed
wants to merge 11 commits into from

Conversation

dkijania
Copy link
Member

@dkijania dkijania commented Feb 27, 2023

Explain your changes:

This PR is an attempt to gather code coverage report from e2e-tests (rather than unit tests) using bisect_ppx.
Idea is to build mina with --instrument-with parameter and then prepare docker which can be use in for example test_executive run.

Explain how you tested your changes:

Currently i tested it locally using some simple command like mina client status and verifying that coverage report is produced.
Then i tried to use multiple packages of mina and start small local network. However there is a problem with setting custom location for bisect artifact. Solution from guide https://github.com/aantron/bisect_ppx/blob/master/doc/advanced.md#environment-variables does not work. And bisect coverage files are put in main mina folder . I tried both environment variable and:

(instrumentation
 (backend bisect_ppx
  --bisect-file /tmp/mycoverage
  --bisect-silent /tmp/coverage.log
  --bisect-sigterm))

Checklist:

  • Fix compilation issues when enabling --instrument-with bisect_ppx argument
  • Build docker with instrumentation enabled
  • Prepare test run using mina package with instrumentation

@dkijania
Copy link
Member Author

!ci-build-me

@dkijania dkijania changed the base branch from develop to test/berkeley-test-feb-10 February 27, 2023 11:21
@dkijania
Copy link
Member Author

!ci-build-me

@dkijania dkijania self-assigned this Feb 27, 2023
@dkijania dkijania force-pushed the add_instrumentation_to_mina_build branch from acba2fd to 4b92064 Compare February 28, 2023 06:10
@dkijania dkijania changed the base branch from test/berkeley-test-feb-10 to rampup February 28, 2023 06:11
@dkijania dkijania closed this Mar 7, 2023
@dkijania dkijania force-pushed the add_instrumentation_to_mina_build branch from 1fe0be2 to ae78a64 Compare March 7, 2023 17:29
@dkijania dkijania reopened this Mar 7, 2023
@dkijania dkijania changed the base branch from rampup to develop March 15, 2023 16:06
@dkijania dkijania force-pushed the add_instrumentation_to_mina_build branch from b4ad445 to ac04f7b Compare March 15, 2023 17:09
@dkijania dkijania marked this pull request as ready for review March 15, 2023 18:53
@dkijania dkijania requested a review from a team as a code owner March 15, 2023 18:53
@dkijania dkijania force-pushed the add_instrumentation_to_mina_build branch from f734d36 to 7cb5c05 Compare March 16, 2023 14:14
@dkijania dkijania force-pushed the add_instrumentation_to_mina_build branch from 260da4a to b43c6b7 Compare April 11, 2023 19:42
@dkijania dkijania changed the title Add instrumentation to mina build [Test-executive] Download coverage files from pods Apr 13, 2023
@dkijania dkijania force-pushed the add_instrumentation_to_mina_build branch from 993055e to 271cfc6 Compare April 13, 2023 09:11
@dkijania dkijania force-pushed the add_instrumentation_to_mina_build branch from 271cfc6 to ea56ada Compare April 24, 2023 07:05
@dkijania dkijania requested a review from a team as a code owner April 24, 2023 07:05
@dkijania dkijania force-pushed the add_instrumentation_to_mina_build branch from ea56ada to 9a5a877 Compare April 24, 2023 07:11
@dkijania dkijania force-pushed the add_instrumentation_to_mina_build branch from 9a5a877 to 4e25018 Compare April 25, 2023 09:47
…ished. Added first step to unit tests for pushing partial coverage data
…enabled. Fix or excluded coverage for broken source files
@dkijania dkijania force-pushed the add_instrumentation_to_mina_build branch from 4e25018 to b1c219a Compare April 25, 2023 13:04
@mergify
Copy link
Contributor

mergify bot commented Apr 25, 2023

⚠️ The sha of the head commit of this PR conflicts with #12868. Mergify cannot evaluate rules on this PR. ⚠️

1 similar comment
@mergify
Copy link
Contributor

mergify bot commented May 2, 2023

⚠️ The sha of the head commit of this PR conflicts with #12868. Mergify cannot evaluate rules on this PR. ⚠️

@dkijania dkijania closed this May 5, 2023
@dkijania dkijania deleted the add_instrumentation_to_mina_build branch May 5, 2023 08:34
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Generate code coverage report for test executive run
1 participant