Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Include vereisten and maatregelen #60

Merged
merged 12 commits into from
Oct 16, 2024
Merged

Include vereisten and maatregelen #60

merged 12 commits into from
Oct 16, 2024

Conversation

ravimeijerrig
Copy link
Contributor

@ravimeijerrig ravimeijerrig commented Oct 9, 2024 •
edited
Loading

Description

In this PR we:

  • Include all vereisten and maatregelen for 1 ai act profile: AI-systeem, hoog-risico, geen transparantieverplichtingen en gebruiksverantwoordelijke.

To consider:

  • maatregelen do not have an URN in AK yet. We have discussed the pattern with them to hopefully align smoothly.

Resolves #

Checklist

Please check all the boxes that apply to this pull request using "x":

  • I have tested the changes locally and verified that they work as expected.
  • I have followed the project's coding conventions and style guidelines.
  • I have rebased my branch onto the latest commit of the main branch.
  • I have squashed or reorganized my commits into logical units.
  • I have read, understood and agree to the Developer Certificate of Origin, which this project utilizes.

@ravimeijerrig ravimeijerrig changed the title Feature/include vereisten Include vereisten and maatregelen Oct 9, 2024
anneschuth
anneschuth approved these changes Oct 9, 2024
View reviewed changes
Copy link
Member

@anneschuth anneschuth left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good. I just think that we should ensure that also the new requirements/*.yaml are validated.

@ravimeijerrig ravimeijerrig force-pushed the feature/include_vereisten branch from 38583a4 to 0783a28 Compare October 14, 2024 11:03
@ravimeijerrig ravimeijerrig marked this pull request as ready for review October 15, 2024 09:01
@ravimeijerrig ravimeijerrig requested a review from a team as a code owner October 15, 2024 09:01
@ravimeijerrig ravimeijerrig linked an issue Oct 15, 2024 that may be closed by this pull request
Add relevant measures and requirements to task registry #61
Closed
@ravimeijerrig ravimeijerrig force-pushed the feature/include_vereisten branch from 75b3dcb to bca3d4a Compare October 15, 2024 09:21
@sonarqubecloud SonarQubeCloud
Copy link

Quality Gate Passed Quality Gate passed

Issues
0 New issues
0 Accepted issues

Measures
0 Security Hotspots
0.0% Coverage on New Code
0.0% Duplication on New Code

See analysis details on SonarCloud

ChristopherSpelt
ChristopherSpelt approved these changes Oct 16, 2024
View reviewed changes
Copy link
Contributor

@ChristopherSpelt ChristopherSpelt left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

lgtm

@ravimeijerrig ravimeijerrig merged commit 9d515be into main Oct 16, 2024
15 checks passed
@ravimeijerrig ravimeijerrig deleted the feature/include_vereisten branch October 16, 2024 08:42
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@anneschuth anneschuth anneschuth approved these changes

@ChristopherSpelt ChristopherSpelt ChristopherSpelt approved these changes

@laurensWe laurensWe Awaiting requested review from laurensWe

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Add relevant measures and requirements to task registry
3 participants
@ravimeijerrig @anneschuth @ChristopherSpelt