systemcard path and required updated based on PR comments

MinBZK · Jun 26, 2024 · 96c9449 · 96c9449
1 parent 9e02a4c
commit 96c9449
Show file tree

Hide file tree

Showing 2 changed files with 19 additions and 26 deletions.
diff --git a/instruments/technical_docs_for_high_risk_ai.yaml b/instruments/technical_docs_for_high_risk_ai.yaml
@@ -33,7 +33,7 @@ tasks:
     type: "open_question"
     suggested_roles: [ ]
     lifecycle: [ ]
-    links: [ {"text": "DPIA vraag 4"}, {"urn": "urn:nl:aivt:ir:1.0:1.2.1"}, {"text": "system_card0.1a4:  goal_and_impact"}]     #TO DO: find a way to link to specific system card fields
+    links: [ {"text": "DPIA vraag 4"}, {"urn": "urn:nl:aivt:ir:1.0:1.2.1"}, {"systemcard_path": ".goal_and_impact", "version": ">0.1a1"}]     #TO DO: find a way to link to specific system card fields
     required: [ ]
     depends_on: [ ]
     template: *assessmentcard_template
@@ -45,7 +45,7 @@ tasks:
     type: "open_question"
     suggested_roles: [ ]
     lifecycle: [ ]
-    links: [ {"text": "system_card0.1a4:  organization"}, {"text": "system_card0.1a4:  external_providers"}]
+    links: [{"systemcard_path": ".organization", "version": ">0.1a1"}, {"systemcard_path": ".external_providers", "version": ">0.1a1"}]
     required: [ ]
     depends_on: [ ]
     template: *assessmentcard_template
@@ -145,7 +145,7 @@ tasks:
     type: "open_question"
     suggested_roles: [ ]
     lifecycle: [ ]
-    links: [{"text": "system_card0.1a4:  description"}]
+    links: [{"systemcard_path": ".description", "version": ">0.1a1"}]
     required: [ ]
     depends_on: [ ]
     template: *assessmentcard_template
@@ -157,7 +157,7 @@ tasks:
     type: "open_question"
     suggested_roles: [ ]
     lifecycle: [ ]
-    links: [{"text": "system_card0.1a4:  description"}]
+    links: [{"systemcard_path": ".description", "version": ">0.1a1"}]
     required: [ ]
     depends_on: [ ]
     template: *assessmentcard_template
@@ -169,7 +169,7 @@ tasks:
     type: "open_question"
     suggested_roles: [ ]
     lifecycle: [ ]
-    links: [{"text": "model card:  task_type"}]
+    links: [ {"systemcard_path": "./models//task_type", "version": ">0.1a1"}]
     required: [ ]
     depends_on: [ ]
     template: *assessmentcard_template
@@ -181,7 +181,7 @@ tasks:
     type: "open_question"
     suggested_roles: [ ]
     lifecycle: [ ]
-    links: [{"text": "model card:  metrics"}]
+    links: [{"systemcard_path": "./models//metrics", "version": ">0.1a1"}]
     required: [ ]
     depends_on: [ ]
     template: *assessmentcard_template
@@ -205,7 +205,7 @@ tasks:
     type: ["upload_document", "open_question"]
     suggested_roles: [ ]
     lifecycle: [ ]
-    links: [{"text": "system_card0.1a4:  external_providers"}]
+    links: [{"systemcard_path": ".external_providers", "version": ">0.1a1"}]
     required: [ ]
     depends_on: [ ]
     template: *assessmentcard_template
@@ -229,7 +229,7 @@ tasks:
     type: "open_question"
     suggested_roles: [ ]
     lifecycle: [ ]
-    links: [ {"text": "model card:  metrics"}, {"text": "system_card0.1a4: used_data"}]
+    links: [ {"systemcard_path": "./models//metrics", "version": ">0.1a1"}, {"systemcard_path": ".used_data", "version": ">0.1a1"}]
     required: [ ]
     depends_on: [ ]
     template: *assessmentcard_template
@@ -241,7 +241,7 @@ tasks:
     type: "open_question"
     suggested_roles: [ ]
     lifecycle: [ ]
-    links: [ {"text": "system_card0.1a4:  human_intervention"} ]
+    links: [ {"systemcard_path": ".human_intervention", "version": ">0.1a1"} ]
     required: [ ]
     depends_on: [ ]
     template: *assessmentcard_template
@@ -277,7 +277,7 @@ tasks:
     type: "open_question"
     suggested_roles: [ ]
     lifecycle: [ ]
-    links: [ {"text": "model card:  metrics"}]
+    links: [ {"systemcard_path": "./models//metrics", "version": ">0.1a1"}]
     required: [ ]
     depends_on: [ ]
   - question: "Beschrijf de gehanteerde cyberbeveilighingsmaatregelen."
@@ -312,7 +312,7 @@ tasks:
     type: "open_question"
     suggested_roles: [ ]
     lifecycle: [ ]
-    links: [ {"text": "model card:  metrics"}]
+    links: [ {"systemcard_path": "./models//metrics", "version": ">0.1a1"}]
     required: [ ]
     depends_on: [ ]
     template: *assessmentcard_template
@@ -324,7 +324,7 @@ tasks:
     type: "open_question"
     suggested_roles: [ ]
     lifecycle: [ ]
-    links: [ {"text": "system_card0.1a4:  risk_management"} ]
+    links: [ {"systemcard_path": ".risk_management", "version": ">0.1a1"}]
     required: [ ]
     depends_on: [ ]
     template: *assessmentcard_template

diff --git a/schema.json b/schema.json
@@ -110,7 +110,6 @@
               "open_question",
               "closed_question",
               "sign_task",
-              "sign_task",
               "upload_document"
             ]
           },
@@ -178,18 +177,12 @@
           },
           "required": {
             "description": "Whether the task is required to be done",
-            "type": "array",
-            "items": {
-              "type": "object",
-              "properties": {
-                "text": {
-                  "type": "string"
-                },
-                "urn": {
-                  "type": "string"
-                }
-              }
-            }
+            "type": "string",
+            "enum": [
+              "mandatory",
+              "conditional",
+              "optional"
+            ]
           },
           "depends_on": {
             "description": "Specific tasks that are required to be completed before this current task",
@@ -248,7 +241,7 @@
           "suggested_roles",
           "lifecycle",
           "links",
-          "requirements",
+          "required",
           "template"
         ]
       }